RESOLVED FIXED 52364
Make old-run-webkit-tests more robust on buildbots 
https://bugs.webkit.org/show_bug.cgi?id=52364
Summary Make old-run-webkit-tests more robust on buildbots
Csaba Osztrogonác
Reported 2011-01-13 05:28:17 PST
Maciej committed a debug print accidentally (http://trac.webkit.org/changeset/75682) and it made all layout tests fail and buildbots sick. The size of results for ~22000 failing layout tests is more than 100Mb. I propose some changes to avoid overloading buildbot slaves and master: 1.) add --exit-after-n-failures 500 option to the old-run-webkit-tests It is enough for online rebaselineing and avoiding 100Mb sizes results 2.) old-run-webkit-tests should remove results directory before testing (Now test-result-archive does it after zipping. But if it is terminated or killed, the results directory will contain some mess.) Patches are coming soon.
Attachments
old-run-webkit-tests fix (1.16 KB, patch)
2011-01-13 05:31 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
exit-after-n-failures 500 patch (1.49 KB, patch)
2011-01-13 05:36 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-01-13 05:31:05 PST
Created attachment 78798 [details] old-run-webkit-tests fix
Csaba Osztrogonác
Comment 2 2011-01-13 05:36:15 PST
Created attachment 78799 [details] exit-after-n-failures 500 patch
Darin Adler
Comment 3 2011-01-13 09:14:23 PST
Comment on attachment 78798 [details] old-run-webkit-tests fix Seems OK. As long as rmtree is available in all the versions of perl we support, and error handling works. I’ll be optimistic.
Darin Adler
Comment 4 2011-01-13 09:15:12 PST
Comment on attachment 78799 [details] exit-after-n-failures 500 patch View in context: https://bugs.webkit.org/attachment.cgi?id=78799&action=review Not great to attach two patches to the same bug. > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:196 > + WithProperties("--%(configuration)s"), "--exit-after-n-crashes-or-timeouts", "20", "--exit-after-n-failures", "500"] Would be slightly better to have a comment explaining the reason for this. There’s also an extra space after the comma.
WebKit Commit Bot
Comment 5 2011-01-13 10:23:15 PST
Comment on attachment 78798 [details] old-run-webkit-tests fix Clearing flags on attachment: 78798 Committed r75721: <http://trac.webkit.org/changeset/75721>
WebKit Commit Bot
Comment 6 2011-01-13 10:37:49 PST
Comment on attachment 78799 [details] exit-after-n-failures 500 patch Clearing flags on attachment: 78799 Committed r75726: <http://trac.webkit.org/changeset/75726>
WebKit Commit Bot
Comment 7 2011-01-13 10:37:55 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2011-01-13 13:11:42 PST
http://trac.webkit.org/changeset/75726 might have broken Leopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.