Bug 52363 – Rename RGBA32Buffer to ImageFrame

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Rename RGBA32Buffer to DecodedImage

[Adam Barth]

Created attachment 78793 [details]
Patch

[WebKit Review Bot]

Attachment 78793 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.h:61:  The parameter name "disposalMethod" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/image-decoders/gif/GIFImageReader.h:104:  disposal_method is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 78793 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7590011

[Eric Seidel (no email)]

Comment on attachment 78793 [details]
Patch

rs=me.

[WebKit Review Bot]

Attachment 78793 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7615007

[Peter Kasting]

Are you sure about DecodedImage?  I had been thinking of using ImageFrame, which I thought would be clearer in the case of animated images that contain multiple frames (where one might assume the "DecodedImage" contained all frames).

I also wanted to move this class to platform/graphics at some point.

[Adam Barth]

> Are you sure about DecodedImage?

Nope!  That's why I posted it for review.  :)

> I had been thinking of using ImageFrame, which I thought would be clearer in the case of animated images that contain multiple frames (where one might assume the "DecodedImage" contained all frames).

Is ImageFrame better than FrameBuffer?  That's what a bunch of methods are called now.

> I also wanted to move this class to platform/graphics at some point.

Yes!  All in good time.

[Peter Kasting]

(In reply to comment #7)
> > I had been thinking of using ImageFrame, which I thought would be clearer in the case of animated images that contain multiple frames (where one might assume the "DecodedImage" contained all frames).
> 
> Is ImageFrame better than FrameBuffer?  That's what a bunch of methods are called now.

Well, it's more consistent with other "ImageXXX" class names.  I'm not sure how meaningful "buffer" is.  But the biggest problem with the original name was the "RGBA32" part.

[Adam Barth]

ImageFrame it is.

[Adam Barth]

Created attachment 78861 [details]
Patch

[WebKit Review Bot]

Attachment 78861 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.h:61:  The parameter name "disposalMethod" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/image-decoders/gif/GIFImageReader.h:104:  disposal_method is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Committed r75748: <http://trac.webkit.org/changeset/75748>

[Daniel Bates]

Renamed bug title so that it is consistent with the bug title mentioned in the change log entry for changeset 75748 <http://trac.webkit.org/changeset/75748>.

[Adam Barth]

Thanks Dan.