Bug 52341 - fast/canvas/canvas-large-dimensions.html (introduced in r75648) is failing on all platforms except Snow Leopard
Summary: fast/canvas/canvas-large-dimensions.html (introduced in r75648) is failing on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Matthew Delaney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 17:35 PST by Justin Schuh
Modified: 2011-04-07 10:11 PDT (History)
20 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2011-01-13 12:34 PST, Matthew Delaney
jamesr: review+
Details | Formatted Diff | Diff
Addition of support for falling back to software rendering when creating a canvas that is too large for the GPU device. (9.56 KB, patch)
2011-04-04 10:46 PDT, Jeff Timanus
no flags Details | Formatted Diff | Diff
Patch (14.08 KB, patch)
2011-04-07 10:10 PDT, Jeff Timanus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Schuh 2011-01-12 17:35:24 PST
I don't know exactly what change, but this seems like the culprit: http://trac.webkit.org/changeset/75639

Snow Leopard appears to be the only platform that's passing.
Comment 1 Hayato Ito 2011-01-12 21:07:53 PST
We disabled this test for chromium and chromium-gpu:

https://trac.webkit.org/changeset/75666
https://trac.webkit.org/changeset/75678
Comment 2 Ryosuke Niwa 2011-01-12 21:24:23 PST
The test was added in http://trac.webkit.org/changeset/75648.  It can't possibly be failing on r75639.
Comment 3 Hayato Ito 2011-01-12 21:29:17 PST
You are right. The comments in the test_expectations files are wrong.
r57648 is correct.

(In reply to comment #2)
> The test was added in http://trac.webkit.org/changeset/75648.  It can't possibly be failing on r75639.
Comment 4 Hayato Ito 2011-01-12 21:30:21 PST
s/r57648/r75648/.

(In reply to comment #3)
> You are right. The comments in the test_expectations files are wrong.
> r57648 is correct.
> 
> (In reply to comment #2)
> > The test was added in http://trac.webkit.org/changeset/75648.  It can't possibly be failing on r75639.
Comment 5 Ryosuke Niwa 2011-01-12 21:30:32 PST
Regression is P1.  Currently, this is the only test failing on GTK 64-bit debug, GTK 32-bit release, Leopard Intel Release, and Leopard Intel Debug and this bug needs to be fixed ASAP.
Comment 6 Ryosuke Niwa 2011-01-12 21:38:36 PST
Oops, thanks for fixing the typo in the summary, Simon.
Comment 7 Justin Schuh 2011-01-13 06:53:04 PST
(In reply to comment #2)
> The test was added in http://trac.webkit.org/changeset/75648.  It can't possibly be failing on r75639.

Apologies for the confusion. I was in a hurry and must have grabbed the wrong version number.
Comment 8 Stephen White 2011-01-13 11:09:07 PST
(In reply to comment #7)
> (In reply to comment #2)
> > The test was added in http://trac.webkit.org/changeset/75648.  It can't possibly be failing on r75639.
> 
> Apologies for the confusion. I was in a hurry and must have grabbed the wrong version number.

Skia has a hard limit in each dimension right now, I think it's 32K, to avoid overflow inside skia.  I think wjmaclean implemented it.  I don't think we can pass this test as-written, since 100K is too big.

reed@ just told me that there's a #define to allow larger bitmaps inside skia, but I don't know if this applies to canvases too.
Comment 9 Matthew Delaney 2011-01-13 12:11:46 PST
The two checks inside the test for making a canvas of width 100k and 1000k are what fails on all the other platforms. I'm going to remove those from the test and add in one that is ~32k that all the platforms should be able to handle. Then we (still) have a test that stresses absurdly large sized canvases but makes sense for all platforms. As a follow up, I'll create a bugzilla to track the discussion of sizes larger than this.
Comment 10 Matthew Delaney 2011-01-13 12:34:14 PST
Created attachment 78841 [details]
Patch
Comment 11 James Robinson 2011-01-13 12:36:15 PST
Comment on attachment 78841 [details]
Patch

Looks good
Comment 12 Matthew Delaney 2011-01-13 12:40:09 PST
<http://trac.webkit.org/changeset/75732>
Comment 13 Jeff Timanus 2011-04-04 10:46:27 PDT
Created attachment 88078 [details]
Addition of support for falling back to software rendering when creating a canvas that is too large for the GPU device.
Comment 14 WebKit Review Bot 2011-04-04 11:07:16 PDT
Attachment 88078 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1

Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:142:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 James Robinson 2011-04-04 11:11:23 PDT
Please post this patch on a new, separate bug.
Comment 16 James Robinson 2011-04-04 11:12:05 PDT
Comment on attachment 88078 [details]
Addition of support for falling back to software rendering when creating a canvas that is too large for the GPU device.

Not valid for this bug (please file another one for the chromium-specific issue)
Comment 17 Jeff Timanus 2011-04-07 10:10:23 PDT
Created attachment 88655 [details]
Patch