Bug 52331 - Get the new drawing area painting to the screen
Summary: Get the new drawing area painting to the screen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 15:47 PST by Anders Carlsson
Modified: 2011-01-12 16:41 PST (History)
0 users

See Also:

Attachments
Patch (4.89 KB, patch)
2011-01-12 15:51 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-12 15:47:49 PST 
Get the new drawing area painting to the screen
Comment 1 Anders Carlsson 2011-01-12 15:51:48 PST 
Created attachment 78750 [details]
Patch
Comment 2 Sam Weinig 2011-01-12 15:55:50 PST 
Comment on attachment 78750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78750&action=review

> WebKit2/UIProcess/mac/BackingStoreMac.mm:51
> +    size_t sizeInBytes = CGBitmapContextGetBytesPerRow(m_bitmapContext.get()) * CGBitmapContextGetHeight(m_bitmapContext.get());
> +    RetainPtr<CGDataProviderRef> dataProvider(AdoptCF, CGDataProviderCreateWithData(0, CGBitmapContextGetData(m_bitmapContext.get()), sizeInBytes, 0));
> +                                                       CGBitmapContextGetHeight(m_bitmapContext.get()),
> +                                                       CGBitmapContextGetBitsPerPixel(m_bitmapContext.get()),
> +                                                       CGBitmapContextGetBytesPerRow(m_bitmapContext.get()),
> +                                                       CGBitmapContextGetColorSpace(m_bitmapContext.get()),
> +                                                       CGBitmapContextGetBitmapInfo(m_bitmapContext.get()),
> +                                                       dataProvider.get(), 0, false, kCGRenderingIntentDefault));
> +
> +    CGFloat imageWidth = CGImageGetWidth(image.get());

We should move this code to a shared function at somepoint. Please add a fixme.
Comment 3 Anders Carlsson 2011-01-12 16:41:27 PST 
Committed r75657: <http://trac.webkit.org/changeset/75657>