Bug 52310 - [chromium] DrawingBuffer and accel canvas giving GL errors
Summary: [chromium] DrawingBuffer and accel canvas giving GL errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 10:48 PST by Stephen White
Modified: 2011-01-12 13:58 PST (History)
4 users (show)

See Also:


Attachments
Patch (10.74 KB, patch)
2011-01-12 11:03 PST, Stephen White
no flags Details | Formatted Diff | Diff
Patch (10.73 KB, patch)
2011-01-12 12:27 PST, Stephen White
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-01-12 10:48:19 PST
Running chromium/linux --enable-accelerated-2d-canvas in Debug, many GL errors are printed to stdout.

glRenderbufferStorage() gives INVALID_ENUM on internalformat
glFramebufferTexture2D() gives INVALID_ENUM on target
glDrawArrays() gives invalid enum (probably due to the first two errors, drawing to an invalid FBO).

The first two seem to be issued by DrawingBuffer.

This may be related to http://code.google.com/p/chromium/issues/detail?id=65139.
Comment 1 Stephen White 2011-01-12 11:03:47 PST
Created attachment 78709 [details]
Patch
Comment 2 James Robinson 2011-01-12 11:06:27 PST
Comment on attachment 78709 [details]
Patch

R=me.  Thanks!
Comment 3 Stephen White 2011-01-12 11:18:49 PST
Will wait for mac EWS results, since I made those changes blind.
Comment 4 WebKit Review Bot 2011-01-12 11:42:30 PST
Attachment 78709 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7342441
Comment 5 James Robinson 2011-01-12 11:49:21 PST
Comment on attachment 78709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78709&action=review

> Source/WebCore/platform/graphics/gpu/mac/DrawingBufferMac.mm:45
> +    , m_multisampleExtensionSupported(multisampleExtensionSupported),

you have a trailing comma here
Comment 6 Stephen White 2011-01-12 12:27:46 PST
Created attachment 78723 [details]
Patch
Comment 7 Stephen White 2011-01-12 13:58:34 PST
Committed r75637: <http://trac.webkit.org/changeset/75637>