Bug 52308 - show shared lines on both sides in code review tool
Summary: show shared lines on both sides in code review tool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 10:43 PST by Ojan Vafai
Modified: 2011-01-27 18:43 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2011-01-12 10:45 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows (12.02 KB, patch)
2011-01-27 18:42 PST, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-01-12 10:43:49 PST 
show shared lines on both sides in code review tool
Comment 1 Ojan Vafai 2011-01-12 10:45:50 PST 
Created attachment 78706 [details]
Patch
Comment 2 WebKit Commit Bot 2011-01-12 14:56:08 PST 
The commit-queue encountered the following flaky tests while processing attachment 78706 [details]:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2011-01-12 14:58:52 PST 
Comment on attachment 78706 [details]
Patch

Clearing flags on attachment: 78706

Committed r75642: <http://trac.webkit.org/changeset/75642>
Comment 4 WebKit Commit Bot 2011-01-12 14:58:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Roben (:aroben) 2011-01-27 18:42:14 PST 
Created attachment 80397 [details]
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows
Comment 6 Adam Roben (:aroben) 2011-01-27 18:43:01 PST 
Comment on attachment 80397 [details]
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows

Whoops, wrong bug!