Bug 52307 - Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
Summary: Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 10:41 PST by Maciej Stachowiak
Modified: 2011-01-12 10:55 PST (History)
0 users

See Also:

Attachments
Patch (1.58 KB, patch)
2011-01-12 10:44 PST, Maciej Stachowiak 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2011-01-12 10:41:49 PST 
Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
Comment 1 Maciej Stachowiak 2011-01-12 10:44:35 PST 
Created attachment 78705 [details]
Patch
Comment 2 Maciej Stachowiak 2011-01-12 10:55:35 PST 
Committed r75623: <http://trac.webkit.org/changeset/75623>
Comment 3 Adam Roben (:aroben) 2011-01-12 10:55:48 PST 
Comment on attachment 78705 [details]
Patch

The review page seems broken at the moment, so reviewing this manually.

+my $noBuildDumpTool = 0;

I find positive names easier to understand, so I'd prefer:

my $buildDumpTool = 1;


+    'no-build' => \$noBuildDumpTool,

Then this can become:

'build!' => \$buildDumpTool,

That will support both --build and --no-build.

You should add this new option to the usage notes.

+if (!defined($root) && !$noBuildDumpTool) {

This will of course have to change, too.