Bug 52293 - Web Inspector: move lastWMLErrorMessage from Console to LayoutTestController
Summary: Web Inspector: move lastWMLErrorMessage from Console to LayoutTestController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 05:22 PST by Yury Semikhatsky
Modified: 2011-02-02 02:26 PST (History)
12 users (show)

See Also:


Attachments
Patch (4.41 KB, patch)
2011-01-13 07:16 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-01-12 05:22:43 PST
Web Inspector: move lastWMLErrorMessage from Console to LayoutTestController. This method is only used on layout tests and should not be exposed as part of public console API.
Comment 1 Joseph Pecoraro 2011-01-12 08:49:04 PST
I like this idea. I wonder if there is a way we can tell if it is still used anywhere in the wild.
Although this would remove a public API and could technically break a website, it is really
only for debugging code (as with all console.* functions) so I think this would be fine. I
can't imagine anyone using this in the wild either.
Comment 2 Nikolas Zimmermann 2011-01-13 03:02:50 PST
(In reply to comment #1)
> I like this idea. I wonder if there is a way we can tell if it is still used anywhere in the wild.
> Although this would remove a public API and could technically break a website, it is really
> only for debugging code (as with all console.* functions) so I think this would be fine. I
> can't imagine anyone using this in the wild either.

This API never shipped, I only added it as debugging helper. Note that WML doesn't support JavaScript, so it was never reachable from a WML page....
Comment 3 Yury Semikhatsky 2011-01-13 03:32:14 PST
(In reply to comment #2)
> (In reply to comment #1)
> > I like this idea. I wonder if there is a way we can tell if it is still used anywhere in the wild.
> > Although this would remove a public API and could technically break a website, it is really
> > only for debugging code (as with all console.* functions) so I think this would be fine. I
> > can't imagine anyone using this in the wild either.
> 
> This API never shipped, I only added it as debugging helper. Note that WML doesn't support JavaScript, so it was never reachable from a WML page....

There are three layout tests that call this method (http://codesearch.google.com/codesearch?hl=en&vert=chromium&lr=&q=lastWMLErrorMessage+file:LayoutTests&sbtn=Search), all of them are failing as I can see, should we remove them?
Comment 4 Yury Semikhatsky 2011-01-13 07:16:16 PST
Created attachment 78807 [details]
Patch
Comment 5 Yury Semikhatsky 2011-02-02 02:26:44 PST
Closing this bug as it was fixed as part of r75792.