RESOLVED FIXED 52284
Split Host object off from WebKitPatch for easier re-use 
https://bugs.webkit.org/show_bug.cgi?id=52284
Summary Split Host object off from WebKitPatch for easier re-use
Eric Seidel (no email)
Reported 2011-01-12 02:46:51 PST
Split Host object off from WebKitPatch for easier re-use
Attachments
Patch (7.90 KB, patch)
2011-01-12 02:47 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.92 KB, patch)
2011-01-21 01:37 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-01-12 02:47:47 PST
Created attachment 78669 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-12 02:49:19 PST
Should be trivial to write additional scripts which use webkitpy (including steps and command objects) w/o being webkit-patch now.
Adam Barth
Comment 3 2011-01-12 02:57:05 PST
Comment on attachment 78669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78669&action=review We should probably rename all the tool variables / properties to host. > Tools/Scripts/webkitpy/common/host.py:30 > +# Command objects expect to have a self.tool which provides these interfaces. Command objects aren't a concept that make sense in common. I'd just remove this comment. > Tools/Scripts/webkitpy/common/host.py:44 > + self.bugs = bugzilla.Bugzilla() > + self.buildbot = buildbot.BuildBot() > + self.executive = executive.Executive() Why don't we just import these names directly instead of using this goofy syntax? > Tools/Scripts/webkitpy/common/host.py:81 > + def command_completed(self): > + if self._irc: > + self._irc.disconnect() This probably needs a more semantic name like disconnect_from_irc > Tools/Scripts/webkitpy/tool/main.py:36 > +from webkitpy.common.host import Host Shouldn't this be alphabetized like everything else?
Eric Seidel (no email)
Comment 4 2011-01-21 01:37:00 PST
Created attachment 79709 [details] Patch for landing
WebKit Commit Bot
Comment 5 2011-01-21 03:23:56 PST
Comment on attachment 79709 [details] Patch for landing Clearing flags on attachment: 79709 Committed r76339: <http://trac.webkit.org/changeset/76339>
WebKit Commit Bot
Comment 6 2011-01-21 03:24:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.