Bug 52283 - Remove premature optimization from SchemeRegistry
Summary: Remove premature optimization from SchemeRegistry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 02:15 PST by Adam Barth
Modified: 2011-01-12 17:40 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2011-01-12 02:18 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-01-12 02:15:35 PST 
Remove premature optimization from SchemeRegistry
Comment 1 Adam Barth 2011-01-12 02:18:38 PST 
Created attachment 78666 [details]
Patch
Comment 2 Adam Barth 2011-01-12 02:59:52 PST 
This code looks to have been added in http://trac.webkit.org/changeset/19952, which doesn't explain why this optimization is necessary.
Comment 3 Adam Barth 2011-01-12 03:00:18 PST 
There might be more information in rdar://problem/4922454, but I can't see it.
Comment 4 Darin Adler 2011-01-12 14:12:07 PST 
(In reply to comment #3)
> There might be more information in rdar://problem/4922454, but I can't see it.

That’s a security bug, so I can give some details here, but probably best to do so in a security-sensitive bug.
Comment 5 Adam Barth 2011-01-12 15:13:35 PST 
I'm marking this bug as security sensitive, not because this issue reflects a security issue but so we can discuss the original motivation for the code we're changing.
Comment 6 Darin Adler 2011-01-12 16:21:49 PST 
Radar bug 4922454 was about http-protocol HTML files being able to load file-protocol scripts. The information in Radar does not any insight into why the fix included the optimized path.

Sorry, didn’t mean to be a tease. I suppose this really isn’t all that security-sensitive. I was rushing and doing multiple things at once and really noticed only that the classification was security.
Comment 7 Adam Barth 2011-01-12 16:25:14 PST 
Thanks for looking in rdar.  I'm going to move this back to non-sensitive so the commit-queue can land the patch.
Comment 8 WebKit Commit Bot 2011-01-12 17:40:06 PST 
Comment on attachment 78666 [details]
Patch

Clearing flags on attachment: 78666

Committed r75664: <http://trac.webkit.org/changeset/75664>
Comment 9 WebKit Commit Bot 2011-01-12 17:40:11 PST 
All reviewed patches have been landed.  Closing bug.