Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks
Summary: WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Yuzo Fujishima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 00:14 PST by Yuzo Fujishima
Modified: 2011-01-19 20:20 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2011-01-12 00:39 PST, Yuzo Fujishima 		no flags Details | Formatted Diff | Diff
Revised ChangeLog (3.28 KB, patch)
2011-01-13 02:21 PST, Yuzo Fujishima 		tkent: review+
yuzo: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuzo Fujishima 2011-01-12 00:14:33 PST 
See http://code.google.com/p/chromium/issues/detail?id=68268

Open 0.html attached to the bug report.
Comment 1 Yuzo Fujishima 2011-01-12 00:39:40 PST 
Created attachment 78662 [details]
Patch
Comment 2 Kent Tamura 2011-01-13 01:34:41 PST 
Comment on attachment 78662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78662&action=review

> Source/WebCore/ChangeLog:11
> +        weird position and a crash will result for documents containing

Could you explain what is "weird position" concretely and why it causes a crash concretely please?
Comment 3 Yuzo Fujishima 2011-01-13 02:21:19 PST 
Created attachment 78789 [details]
Revised ChangeLog
Comment 4 Yuzo Fujishima 2011-01-13 02:22:33 PST 
Thank you for the review.

Updated the ChangeLog. Does it look better?

(In reply to comment #2)
> (From update of attachment 78662 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78662&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        weird position and a crash will result for documents containing
> 
> Could you explain what is "weird position" concretely and why it causes a crash concretely please?
Comment 5 Kent Tamura 2011-01-13 20:11:43 PST 
(In reply to comment #4)
> Updated the ChangeLog. Does it look better?

Does it mean nextObj can be NULL?
Comment 6 Yuzo Fujishima 2011-01-19 16:52:04 PST 
Yes, it can be null and then the crash results.

(In reply to comment #5)
> (In reply to comment #4)
> > Updated the ChangeLog. Does it look better?
> 
> Does it mean nextObj can be NULL?
Comment 7 Kent Tamura 2011-01-19 17:24:06 PST 
Comment on attachment 78789 [details]
Revised ChangeLog

ok, I understand.
Comment 8 Yuzo Fujishima 2011-01-19 17:58:42 PST 
Comment on attachment 78789 [details]
Revised ChangeLog

Thank you for the review.
Comment 9 Yuzo Fujishima 2011-01-19 20:20:05 PST 
Committed r76201: <http://trac.webkit.org/changeset/76201>