Bug 52257 - Change createObjectURL and revokeObjectURL to put under webkitURL
Summary: Change createObjectURL and revokeObjectURL to put under webkitURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 15:26 PST by Jian Li
Modified: 2011-01-13 14:56 PST (History)
7 users (show)

See Also:

Attachments
Proposed Patch (38.72 KB, patch)
2011-01-11 15:31 PST, Jian Li 		jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (39.16 KB, patch)
2011-01-11 16:08 PST, Jian Li 		jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (38.75 KB, patch)
2011-01-11 16:39 PST, Jian Li 		fishd: review+
jianli: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2011-01-11 15:26:39 PST 
Change createObjectURL and revokeObjectURL to put under webkitURL, per the latest version of File API. Note that we add "webkit" vendor prefix to URL.
Comment 1 Jian Li 2011-01-11 15:31:50 PST 
Created attachment 78610 [details]
Proposed Patch
Comment 2 Early Warning System Bot 2011-01-11 15:59:06 PST 
Attachment 78610 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7442120
Comment 3 Jian Li 2011-01-11 16:08:02 PST 
Created attachment 78615 [details]
Proposed Patch

Fixed qt build.
Comment 4 WebKit Review Bot 2011-01-11 16:29:08 PST 
Attachment 78610 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7393154
Comment 5 Jian Li 2011-01-11 16:39:21 PST 
Created attachment 78620 [details]
Proposed Patch

Another fix for qt build.
Comment 6 Darin Fisher (:fishd, Google) 2011-01-12 11:52:16 PST 
Comment on attachment 78620 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78620&action=review

> Source/WebCore/DerivedSources.cpp:97
> +#include "JSDOMUrl.cpp"

nit: I think webkit style is for acronyms in identifiers/names to be either lowercase (if at the start of a name) or UPPERCASE, so this should be JSDOMURL.cpp.

> Source/WebCore/DerivedSources.make:150
> +    DOMUrl \

nit: DOMURL
Comment 7 Jian Li 2011-01-13 14:56:44 PST 
Renamed to DOMURL and committed as https://trac.webkit.org/changeset/75739.