RESOLVED FIXED 52252
[Qt] Use a black background color for the video element on Qt Mobile 
https://bugs.webkit.org/show_bug.cgi?id=52252
Summary [Qt] Use a black background color for the video element on Qt Mobile
Yi Shen
Reported Tuesday, January 11, 2011 10:14:09 PM UTC
According to the UI specification for Html5 inline video on Symbian, if there is no poster defined or video frame data is available, the webpage should display a black box which fits the video element area. The easiest implementation is to use a black background color for the video element. I will add a patch for review soon. Comments & Suggestions are super welcome! :)
Attachments
first try (1016 bytes, patch)
2011-01-11 17:12 PST, Yi Shen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yi Shen
Comment 1 Wednesday, January 12, 2011 1:12:29 AM UTC
Created attachment 78629 [details] first try
Yi Shen
Comment 2 Wednesday, January 12, 2011 9:52:08 PM UTC
Eric, could you also please take a look at this patch? Thx
Eric Seidel (no email)
Comment 3 Wednesday, January 12, 2011 10:02:58 PM UTC
Comment on attachment 78629 [details] first try I mean, I know nothing about this. But I'm willing to rs=me this patch.
Eric Seidel (no email)
Comment 4 Wednesday, January 12, 2011 10:06:39 PM UTC
In general the other eric knows a lot more about <video> and <audio> related stuff. I'm not sure he has much opinion on how <video> looks on symbian (i'm not sure any of us who don't work on symbian really care).
Yi Shen
Comment 5 Wednesday, January 12, 2011 10:18:42 PM UTC
(In reply to comment #4) > In general the other eric knows a lot more about <video> and <audio> related stuff. I'm not sure he has much opinion on how <video> looks on symbian (i'm not sure any of us who don't work on symbian really care). Thanks Eric :) I am going to ask other qt/symbian guys for some comments.
Andreas Kling
Comment 6 Thursday, January 13, 2011 2:49:08 PM UTC
Comment on attachment 78629 [details] first try cq=me ;)
WebKit Commit Bot
Comment 7 Thursday, January 13, 2011 3:29:36 PM UTC
Comment on attachment 78629 [details] first try Clearing flags on attachment: 78629 Committed r75712: <http://trac.webkit.org/changeset/75712>
WebKit Commit Bot
Comment 8 Thursday, January 13, 2011 3:29:43 PM UTC
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 9 Thursday, January 13, 2011 6:57:56 PM UTC
Revision r75712 cherry-picked into qtwebkit-2.2 with commit b92afdd <http://gitorious.org/webkit/qtwebkit/commit/b92afdd>
Note You need to log in before you can comment on or make changes to this bug.