Bug 52235 - [chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
Summary: [chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 12:16 PST by Kenneth Russell
Modified: 2011-01-11 14:16 PST (History)
3 users (show)

See Also:


Attachments
Patch (80.96 KB, patch)
2011-01-11 13:43 PST, Kenneth Russell
jamesr: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-01-11 12:16:08 PST
In http://trac.webkit.org/changeset/65093 , Chromium's in-process WebGL implementation was changed to use Chromium's GL bindings rather than the GLEW library. Unfortunately, I did not realize at the time that this introduced an undesirable circular dependency between Chromium and WebKit.

The solution is to move this class from the WebKit repository to the Chromium repository. The Chromium-side changes have been landed in http://src.chromium.org/viewvc/chrome?view=rev&revision=71069 .
Comment 1 Kenneth Russell 2011-01-11 13:43:22 PST
Created attachment 78590 [details]
Patch
Comment 2 James Robinson 2011-01-11 14:10:35 PST
Comment on attachment 78590 [details]
Patch

R=me. deletion rules!
Comment 3 Kenneth Russell 2011-01-11 14:16:52 PST
Committed r75553: <http://trac.webkit.org/changeset/75553>