RESOLVED FIXED 52231
[WKView setFrameSize:] derefs _page->drawingArea() without null check 
https://bugs.webkit.org/show_bug.cgi?id=52231
Summary [WKView setFrameSize:] derefs _page->drawingArea() without null check
John Sullivan
Reported 2011-01-11 11:55:04 PST
[WKView setFrameSize:] dereferences _data->_page->drawingArea() without testing for null. But the drawing area can be null just after a WKView is created, due to a recent change.
Attachments
Patch that adds a null check. (1.14 KB, patch)
2011-01-11 11:56 PST, John Sullivan 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Sullivan
Comment 1 2011-01-11 11:56:22 PST
Created attachment 78572 [details] Patch that adds a null check.
John Sullivan
Comment 2 2011-01-11 12:06:06 PST
Fixed in r75525.
WebKit Review Bot
Comment 3 2011-01-11 12:27:05 PST
http://trac.webkit.org/changeset/75525 might have broken Windows Release (Build) and Windows Debug (Build)
John Sullivan
Comment 4 2011-01-11 12:35:30 PST
I believe the WebKit Review Bot is oh so very wrong. This patch only affected the contents of one method in one Mac-specific file, so it could not have broken the Windows build.
Note You need to log in before you can comment on or make changes to this bug.