Bug 52231 - [WKView setFrameSize:] derefs _page->drawingArea() without null check
Summary: [WKView setFrameSize:] derefs _page->drawingArea() without null check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: John Sullivan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 11:55 PST by John Sullivan
Modified: 2011-01-11 12:35 PST (History)
3 users (show)

See Also:

Attachments
Patch that adds a null check. (1.14 KB, patch)
2011-01-11 11:56 PST, John Sullivan 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2011-01-11 11:55:04 PST 
[WKView setFrameSize:]  dereferences _data->_page->drawingArea() without testing for null. But the drawing area can be null just after a WKView is created, due to a recent change.
Comment 1 John Sullivan 2011-01-11 11:56:22 PST 
Created attachment 78572 [details]
Patch that adds a null check.
Comment 2 John Sullivan 2011-01-11 12:06:06 PST 
Fixed in r75525.
Comment 3 WebKit Review Bot 2011-01-11 12:27:05 PST 
http://trac.webkit.org/changeset/75525 might have broken Windows Release (Build) and Windows Debug (Build)
Comment 4 John Sullivan 2011-01-11 12:35:30 PST 
I believe the WebKit Review Bot is oh so very wrong. This patch only affected the contents of one method in one Mac-specific file, so it could not have broken the Windows build.