Bug 52229 - Enforce READ_ONLY transactions in IndexedDB
Summary: Enforce READ_ONLY transactions in IndexedDB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 11:29 PST by Jeremy Orlow
Modified: 2011-01-12 02:40 PST (History)
3 users (show)

See Also:

Attachments
Patch (34.24 KB, patch)
2011-01-11 11:32 PST, Jeremy Orlow 		japhet: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2011-01-11 11:29:37 PST 
Enforce READ_ONLY transactions in IndexedDB
Comment 1 Jeremy Orlow 2011-01-11 11:32:29 PST 
Created attachment 78565 [details]
Patch
Comment 2 Jeremy Orlow 2011-01-11 11:33:09 PST 
Andrei/hans, please take a look.

Nate, can you please do the official review?
Comment 3 Nate Chapin 2011-01-11 13:14:17 PST 
Comment on attachment 78565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78565&action=review

The tests have huge diffs for no visible reason, so I'm assuming the line endings changed.  Are they right before or after this patch?

> Source/WebCore/storage/IDBCursorBackendImpl.cpp:169
>  
> -    // FIXME: Check that the transaction is READ_WRITE
> -    // if (m_transaction->mode() == IDBTransaction::READ_ONLY) {
> -        // FIXME: We must return READ_ONLY_ERR here. Fix this when we update IDBDatabaseException to match the spec.
> -        // ec = IDBDatabaseException::NOT_ALLOWED_ERR;
> -        // return;
> -    // }
> +

Looks like two lines of whitespace here.
Comment 4 Hans Wennborg 2011-01-12 02:06:07 PST 
(In reply to comment #2)
> Andrei/hans, please take a look.
Looks good.
Comment 5 Jeremy Orlow 2011-01-12 02:40:57 PST 
Committed r75596: <http://trac.webkit.org/changeset/75596>