Bug 52228 - Rename BackingStore to ShareableBitmap
Summary: Rename BackingStore to ShareableBitmap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 11:28 PST by Anders Carlsson
Modified: 2011-01-11 12:27 PST (History)
4 users (show)

See Also:

Attachments
Patch (78.66 KB, patch)
2011-01-11 11:30 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-11 11:28:57 PST 
Rename BackingStore to ShareableBitmap
Comment 1 Anders Carlsson 2011-01-11 11:30:05 PST 
Created attachment 78563 [details]
Patch
Comment 2 WebKit Review Bot 2011-01-11 11:32:24 PST 
Attachment 78563 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/GNUmakefile...." exit_code: 1
WebKit2/Shared/WebImage.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2011-01-11 11:47:44 PST 
Attachment 78563 [details] did not build on win:
Build output: http://queues.webkit.org/results/7479019
Comment 4 Sam Weinig 2011-01-11 12:09:39 PST 
Comment on attachment 78563 [details]
Patch

r+ with the windows fix.
Comment 5 Anders Carlsson 2011-01-11 12:13:27 PST 
Committed r75527: <http://trac.webkit.org/changeset/75527>
Comment 6 WebKit Review Bot 2011-01-11 12:27:18 PST 
http://trac.webkit.org/changeset/75527 might have broken Windows Release (Build) and Windows Debug (Build)