WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52228
Rename BackingStore to ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=52228
Summary
Rename BackingStore to ShareableBitmap
Anders Carlsson
Reported
2011-01-11 11:28:57 PST
Rename BackingStore to ShareableBitmap
Attachments
Patch
(78.66 KB, patch)
2011-01-11 11:30 PST
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-01-11 11:30:05 PST
Created
attachment 78563
[details]
Patch
WebKit Review Bot
Comment 2
2011-01-11 11:32:24 PST
Attachment 78563
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/GNUmakefile...." exit_code: 1 WebKit2/Shared/WebImage.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3
2011-01-11 11:47:44 PST
Attachment 78563
[details]
did not build on win: Build output:
http://queues.webkit.org/results/7479019
Sam Weinig
Comment 4
2011-01-11 12:09:39 PST
Comment on
attachment 78563
[details]
Patch r+ with the windows fix.
Anders Carlsson
Comment 5
2011-01-11 12:13:27 PST
Committed
r75527
: <
http://trac.webkit.org/changeset/75527
>
WebKit Review Bot
Comment 6
2011-01-11 12:27:18 PST
http://trac.webkit.org/changeset/75527
might have broken Windows Release (Build) and Windows Debug (Build)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug