allow sidebysideifying individual files in the code review tool
Created attachment 78557 [details] Patch
Created attachment 78558 [details] screenshot
The fonts don't seem to match the existing side-by-side links. Also, maybe we should have one link that changes text based on the current state? I'm worried about overloading the reviewtool with lots of UI.
(In reply to comment #3) > The fonts don't seem to match the existing side-by-side links. It's just inheriting the font. I'll fix that. > Also, maybe we should have one link that changes text based on the current state? I'm worried about overloading the reviewtool with lots of UI. I'm sympathetic to this. I think this is valuable though. We can certainly remove it later if people find it to be too much. It's just a few lines of code. I don't have plans to add any other UI after this. The only tasks I have planned for the review tool: -Make side-by-side diffs more minimal by actually putting removed lines to the left of added lines. -Store whether you want side-by-side diffs in the cookie so you can always load the one you prefer by default.
Can we hide the link that's not meaningful (e.g., side-by-side when we're already in side-by-side mode)? Also, I would vertically center the link in the H1.
Comment on attachment 78557 [details] Patch Lets land this with the cosmetic changes discussed above. It would be nice to add the link-hiding in a followup patch.
Committed r75559: <http://trac.webkit.org/changeset/75559>