Bug 52223 - [Qt] Add QT_NO_CONCURRENT to the qt_minimal configuration
Summary: [Qt] Add QT_NO_CONCURRENT to the qt_minimal configuration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P4 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-01-11 10:08 PST by Laszlo Gombos
Modified: 2011-01-11 12:33 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (976 bytes, patch)
2011-01-11 10:10 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2011-01-11 10:08:19 PST
After r75502 QtWebkit runs and builds (again) with QT_NO_CONCURRENT defined. This is important for Qt ports where some of the Qt concurrency classes are not ported yet (e.g. Symbian).

To make sure that we keep an eye on this, add QT_NO_CONCURRENT to the qt_minimal configuration. Once the minimal bot builds with CONFIG+=qt_minimal, build regressions will be immediately revealed.
Comment 1 Laszlo Gombos 2011-01-11 10:10:57 PST
Created attachment 78546 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2011-01-11 10:21:19 PST
In this week I'm going to build a minimal Qt for 
the minimal bot with options in qt_minimal disabled.
Comment 3 WebKit Commit Bot 2011-01-11 12:33:16 PST
Comment on attachment 78546 [details]
proposed patch

Clearing flags on attachment: 78546

Committed r75533: <http://trac.webkit.org/changeset/75533>
Comment 4 WebKit Commit Bot 2011-01-11 12:33:22 PST
All reviewed patches have been landed.  Closing bug.