Bug 52218 - [Qt][V8] window.layoutTestController should exist
Summary: [Qt][V8] window.layoutTestController should exist
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Andras Becsi
URL:
Keywords: Qt, QtTriaged
Depends on: 56649
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-11 09:22 PST by Csaba Osztrogonác
Modified: 2012-11-21 06:13 PST (History)
10 users (show)

See Also:

Attachments
test to demonstrate the bug (430 bytes, text/html)
2011-01-11 09:22 PST, Csaba Osztrogonác 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-01-11 09:22:40 PST 
Created attachment 78543 [details]
test to demonstrate the bug

To make layout tests work with V8-QtWebKit, we have to use 
window.layoutTestController in testcases, but it doesn't exist.

$ WebKitBuild/Debug/bin/DumpRenderTree ./1.html

expected result:  text only output with PASS string
actual result: rendertree dump with FAILED string
Comment 1 Csaba Osztrogonác 2011-02-16 04:19:31 PST 
Guys, have you got any idea how to fix this bug?
It would be great if we could run layout tests with V8-QtWebKit
Comment 2 Simon Hausmann 2011-02-18 00:13:37 PST 
We're waiting for legal review to publish a version of QtScript on Gitorious that uses V8. Once that is in place, we should use that to build QtWebKit+V8, because it contains the necessary QObject bindings behind QWebFrame::addToJavaScriptWindowObject(), so that the existing Qt DRT implementation can be used out of the box with no changes.
Comment 3 Simon Hausmann 2011-03-03 03:15:37 PST 
Ok, http://qt.gitorious.org/qt/qt-script-ng is public now. Just spoke with bbandix on IRC and once the current qtwebkit+v8 build bot is switched over to use that version of Qt, then we can re-enable the QObject bridge and revive the Qt DRT for the v8 build :)
Comment 4 Csaba Osztrogonác 2012-05-23 02:39:29 PDT 
Balázs, Gábor, Péter, is this bug still valid?
Comment 5 Balazs Kelemen 2012-05-23 04:34:21 PDT 
(In reply to comment #4)
> Balázs, Gábor, Péter, is this bug still valid?

For WebKit1 it seems to be invalid now, the test results in PASS. I tested in my own branch (unfortunately trunk v8 build is broken now), but it doesn't contain any changes for WK1, so it should work in trunk after the build has been fixed (Gabor Ballabas is going to upload the fix soon).
Comment 6 Balazs Kelemen 2012-06-16 12:00:50 PDT 
This should work now. Gabor, can you affirm that?
Comment 7 Csaba Osztrogonác 2012-11-21 06:13:33 PST 
Building QtWebKit with V8 isn't supported anymore.