WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
52218
[Qt][V8] window.layoutTestController should exist
https://bugs.webkit.org/show_bug.cgi?id=52218
Summary
[Qt][V8] window.layoutTestController should exist
Csaba Osztrogonác
Reported
2011-01-11 09:22:40 PST
Created
attachment 78543
[details]
test to demonstrate the bug To make layout tests work with V8-QtWebKit, we have to use window.layoutTestController in testcases, but it doesn't exist. $ WebKitBuild/Debug/bin/DumpRenderTree ./1.html expected result: text only output with PASS string actual result: rendertree dump with FAILED string
Attachments
test to demonstrate the bug
(430 bytes, text/html)
2011-01-11 09:22 PST
,
Csaba Osztrogonác
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2011-02-16 04:19:31 PST
Guys, have you got any idea how to fix this bug? It would be great if we could run layout tests with V8-QtWebKit
Simon Hausmann
Comment 2
2011-02-18 00:13:37 PST
We're waiting for legal review to publish a version of QtScript on Gitorious that uses V8. Once that is in place, we should use that to build QtWebKit+V8, because it contains the necessary QObject bindings behind QWebFrame::addToJavaScriptWindowObject(), so that the existing Qt DRT implementation can be used out of the box with no changes.
Simon Hausmann
Comment 3
2011-03-03 03:15:37 PST
Ok,
http://qt.gitorious.org/qt/qt-script-ng
is public now. Just spoke with bbandix on IRC and once the current qtwebkit+v8 build bot is switched over to use that version of Qt, then we can re-enable the QObject bridge and revive the Qt DRT for the v8 build :)
Csaba Osztrogonác
Comment 4
2012-05-23 02:39:29 PDT
Balázs, Gábor, Péter, is this bug still valid?
Balazs Kelemen
Comment 5
2012-05-23 04:34:21 PDT
(In reply to
comment #4
)
> Balázs, Gábor, Péter, is this bug still valid?
For WebKit1 it seems to be invalid now, the test results in PASS. I tested in my own branch (unfortunately trunk v8 build is broken now), but it doesn't contain any changes for WK1, so it should work in trunk after the build has been fixed (Gabor Ballabas is going to upload the fix soon).
Balazs Kelemen
Comment 6
2012-06-16 12:00:50 PDT
This should work now. Gabor, can you affirm that?
Csaba Osztrogonác
Comment 7
2012-11-21 06:13:33 PST
Building QtWebKit with V8 isn't supported anymore.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug