Bug 52215 - Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload
Summary: Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-11 08:44 PST by Pavel Podivilov
Modified: 2011-01-14 07:58 PST (History)
10 users (show)

See Also:


Attachments
Patch. (6.92 KB, patch)
2011-01-11 08:45 PST, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Comments addressed. (8.28 KB, patch)
2011-01-14 05:00 PST, Pavel Podivilov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-01-11 08:44:21 PST
Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload
Comment 1 Pavel Podivilov 2011-01-11 08:45:02 PST
Created attachment 78534 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-01-14 02:22:56 PST
Comment on attachment 78534 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=78534&action=review

> Source/WebCore/inspector/front-end/Breakpoint.js:90
> +        function gotSourceLine(text)

in WebKit didGet... naming style is used

> Source/WebCore/inspector/front-end/Script.js:60
> +WebInspector.Script.findLineEndings = function(source)

This should be declared in utilities.js, maybe on String.prototype

> Source/WebCore/inspector/front-end/Script.js:82
> +    findLineEndings: function(callback)

this method should be private

> Source/WebCore/inspector/front-end/Script.js:123
> +        function gotScriptSource(source)

in WebKit didGet... naming style is used

> Source/WebCore/inspector/front-end/Script.js:127
> +                for (var i = 0; i < this.startingLine - 1; ++i)

why do you need this?

> Source/WebCore/inspector/front-end/Script.js:131


looks like you need to add this message to localizedStrings.js
Comment 3 Pavel Podivilov 2011-01-14 05:00:16 PST
Created attachment 78925 [details]
Comments addressed.
Comment 4 Pavel Podivilov 2011-01-14 07:58:53 PST
Committed r75795: <http://trac.webkit.org/changeset/75795>