WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52204
Web Inspector: innerFirstChild has a side effect which should be done explicitly.
https://bugs.webkit.org/show_bug.cgi?id=52204
Summary
Web Inspector: innerFirstChild has a side effect which should be done explici...
Ilya Tikhonovsky
Reported
2011-01-11 05:34:08 PST
if a node is a frame's owner then innerFirstChild method subscribes DOMAgent instance to the frame's doc's events. I think this should be done explicitly when we meet with the node for the first time. As I understand it happens in buildArrayForContainerChildren method.
Attachments
[patch] initial version.
(4.03 KB, patch)
2011-01-11 05:42 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2011-01-11 05:42:03 PST
Created
attachment 78520
[details]
[patch] initial version.
Pavel Feldman
Comment 2
2011-01-11 05:59:07 PST
Comment on
attachment 78520
[details]
[patch] initial version. View in context:
https://bugs.webkit.org/attachment.cgi?id=78520&action=review
> Source/WebCore/inspector/InspectorDOMAgent.cpp:271 > +void InspectorDOMAgent::startListeningFrameDoc(Node* frameOwnerNode)
startListeningContentDocument?
Ilya Tikhonovsky
Comment 3
2011-01-11 06:14:13 PST
Committed
r75495
M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorDOMAgent.h M Source/WebCore/inspector/InspectorDOMAgent.cpp
r75495
= 170e93b8362250788cc1a6e19e46e50d587729e8 (refs/remotes/trunk)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug