RESOLVED FIXED 52203
[GTK] Remove m_themeParts and m_themePartsHaveRGBAColormap from RenderThemeGtk 
https://bugs.webkit.org/show_bug.cgi?id=52203
Summary [GTK] Remove m_themeParts and m_themePartsHaveRGBAColormap from RenderThemeGtk
Carlos Garcia Campos
Reported 2011-01-11 04:25:14 PST
gtk2drawing.c uses a global static pointer to a GtkThemeParts struct that is set with moz_gtk_use_theme_parts(). RenderThemeGtk2 calls moz_gtk_use_theme_parts() passing m_themeParts, but only for the first RenderThemeGtk instance since it's using a static reference counter. Once there's a RenderThemeGtk instance, all other new instances will have a GtkThemeParts that it's not used except to set the colormap. Since gtk2drawing.c uses a global pointer that is set only once, we could use a static struct instead of an instance member in RenderThemeGtk2.
Attachments
Patch (8.49 KB, patch)
2011-01-11 04:30 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-01-11 04:30:09 PST
Created attachment 78516 [details] Patch
Martin Robinson
Comment 2 2011-01-11 08:23:16 PST
Hmm. I think it makes sense to simply move away from the Mozilla code (I've already started the work -- see https://bugs.webkit.org/show_bug.cgi?id=51155 ). Once that's finished there m_themeParts will be gone. Also, at that point, it won't make sense to have the colormap boolean in the Mozilla code either.
Carlos Garcia Campos
Comment 3 2011-01-11 08:30:19 PST
Ok, so it will be fixed anyway when moving mozilla code to RenderThemeGtk2 then.
Note You need to log in before you can comment on or make changes to this bug.