Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
Created attachment 78485 [details] Patch
Attachment 78485 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/AP..." exit_code: 1 WebKit2/UIProcess/API/mac/WKViewInternal.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r75459: <http://trac.webkit.org/changeset/75459>
(In reply to comment #3) > Committed r75459: <http://trac.webkit.org/changeset/75459> It broke Qt build: ../../../WebKit2/UIProcess/API/qt/qwkpage_p.h:46: error: ‘DrawingAreaProxy’ was not declared in this scope ../../../WebKit2/UIProcess/API/qt/qwkpage_p.h:46: error: template argument 1 is invalid ../../../WebKit2/UIProcess/API/qt/qwkpage_p.h:46: error: conflicting return type specified for ‘virtual int QWKPagePrivate::createDrawingAreaProxy()’ ../../../WebKit2/UIProcess/PageClient.h:53: error: overriding ‘virtual WTF::PassOwnPtr<WebKit::DrawingAreaProxy> WebKit::PageClient::createDrawingAreaProxy()’ Could you guys fix the build or roll it out?
(In reply to comment #3) > Committed r75459: <http://trac.webkit.org/changeset/75459> Rolled-out: http://trac.webkit.org/changeset/75473
Comment on attachment 78485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78485&action=review > WebKit2/UIProcess/API/qt/qwkpage_p.h:46 > + virtual PassOwnPtr<DrawingAreaProxy> createDrawingAreaProxy(); WebKit::DrawingAreaProxy instead of DrawingAreaProxy will make Qt build happier.
Comment on attachment 78485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78485&action=review > WebKit2/UIProcess/API/qt/qwkpage.cpp:126 > +PassOwnPtr<DrawingAreaProxy> QWKPagePrivate::createDrawingAreaProxy() > +{ > + // FIXME: Implement. See https://bugs.webkit.org/show_bug.cgi?id=52183. > +} After fix in Comment #6 I got the following build error: In file included from ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:742: ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp: In member function 'virtual WTF::PassOwnPtr<WebKit::DrawingAreaProxy> QWKPagePrivate::createDrawingAreaProxy()': ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:126: error: control reaches end of non-void function
Created attachment 78528 [details] patch with qt parts Updated patch to TOT with real (non-stub) implementation of qt part.
Attachment 78528 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/AP..." exit_code: 1 WebKit2/UIProcess/API/mac/WKViewInternal.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 78528 [details] patch with qt parts You should get the QGraphicsWKView* via QWKPagePrivate::item instead.
(In reply to comment #10) > (From update of attachment 78528 [details]) > You should get the QGraphicsWKView* via QWKPagePrivate::item instead. Ehm. I just learned that the variable I'm referring to has not hit trunk yet (branches.. grmbl..) We don't want to tie the QWKPage and QGraphicsWKView together like that on the API level though. I'd rather we add a QGraphicsItem* member to QWKPagePrivate and stash the QGraphicsWKView* in there during QWKPagePrivate::init().
Created attachment 78533 [details] Patch
Attachment 78533 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/AP..." exit_code: 1 WebKit2/UIProcess/API/mac/WKViewInternal.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 78533 [details] Patch Better, thanks. r=me
Comment on attachment 78533 [details] Patch Clearing flags on attachment: 78533 Committed r75506: <http://trac.webkit.org/changeset/75506>
All reviewed patches have been landed. Closing bug.
*** Bug 52183 has been marked as a duplicate of this bug. ***