RESOLVED INVALID 52182
Patch holder while updating over WebCore->Source/WebCore tectonic boundary 
https://bugs.webkit.org/show_bug.cgi?id=52182
Summary Patch holder while updating over WebCore->Source/WebCore tectonic boundary
Mike Lawther
Reported 2011-01-10 17:11:31 PST
Patch holder while updating over WebCore->Source/WebCore tectonic boundary
Attachments
Patch (8.38 KB, patch)
2011-01-10 17:53 PST, Mike Lawther 		mikelawther: review-
mikelawther: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Lawther
Comment 1 2011-01-10 17:53:27 PST
Created attachment 78482 [details] Patch
WebKit Review Bot
Comment 2 2011-01-10 17:54:37 PST
Attachment 78482 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.cpp:94: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/css/CSSParser.cpp:1083: One space before end of line comments [whitespace/comments] [5] Source/WebCore/css/CSSParser.cpp:1084: One space before end of line comments [whitespace/comments] [5] Source/WebCore/css/CSSParser.cpp:1089: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/css/CSSParser.cpp:5503: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/css/CSSParser.cpp:5508: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/css/CSSParser.h:170: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2011-01-10 18:02:04 PST
Attachment 78482 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7386113
Early Warning System Bot
Comment 4 2011-01-10 21:43:10 PST
Attachment 78482 [details] did not build on qt: Build output: http://queues.webkit.org/results/7360119
Note You need to log in before you can comment on or make changes to this bug.