Following up from Darin Adler's comment in bug #51866 <https://bugs.webkit.org/show_bug.cgi?id=51866#c16>, it is sufficient to test for GCC_VERSION_AT_LEAST() instead of COMPILER(GCC) && GCC_VERSION_AT_LEAST().
Created attachment 78470 [details] Patch
Comment on attachment 78470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78470&action=review Looks good, but pleae double-check the wording in the ChangeLog. > Source/JavaScriptCore/ChangeLog:11 > + It is sufficient to test GCC_VERSION_AT_LEAST() instead of both COMPILER(GCC) and > + GCC_VERSION_AT_LEAST() as GCC_VERSION_AT_LEAST() is defined only when we are > + compiling with GCC (i.e. COMPILER(GCC) is true). > + Careful with this wording. My reading of this is that GCC_VERSION_AT_LEAST() is undefined when we aren't on GCC, but in actuality GCC_VERSION_AT_LEAST() is defined as 0.
(In reply to comment #2) > (From update of attachment 78470 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78470&action=review > > Looks good, but pleae double-check the wording in the ChangeLog. > > > Source/JavaScriptCore/ChangeLog:11 > > + It is sufficient to test GCC_VERSION_AT_LEAST() instead of both COMPILER(GCC) and > > + GCC_VERSION_AT_LEAST() as GCC_VERSION_AT_LEAST() is defined only when we are > > + compiling with GCC (i.e. COMPILER(GCC) is true). > > + > > Careful with this wording. My reading of this is that GCC_VERSION_AT_LEAST() is undefined when we aren't on GCC, but in actuality GCC_VERSION_AT_LEAST() is defined as 0. Will fix before landing.
Committed r75454: <http://trac.webkit.org/changeset/75454>