Bug 52175 - Use a pull model for view state changes
Summary: Use a pull model for view state changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-10 15:54 PST by Anders Carlsson
Modified: 2011-01-10 16:47 PST (History)
0 users

See Also:

Attachments
Patch (27.20 KB, patch)
2011-01-10 15:58 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-10 15:54:17 PST 
Use a pull model for view state changes
Comment 1 Anders Carlsson 2011-01-10 15:58:39 PST 
Created attachment 78465 [details]
Patch
Comment 2 mitz 2011-01-10 16:04:40 PST 
Comment on attachment 78465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78465&action=review

> WebKit2/UIProcess/WebPageProxy.h:176
> +    enum ViewStateFlags {
> +        IsViewWindowActive = 1 << 0,
> +        IsViewFocused = 1 << 1,
> +        IsViewVisible = 1 << 2,
> +        IsViewInWindow = 1 << 3
> +    };

It’s not good that the value names read like questions.

> WebKit2/UIProcess/WebPageProxy.h:177
> +    void viewStateDidChange(unsigned flags);

It would be better to have a typedef for this instead of using unsigned.
Comment 3 Sam Weinig 2011-01-10 16:40:34 PST 
Comment on attachment 78465 [details]
Patch

r=me, though please consider making the changes mitz advised.
Comment 4 Anders Carlsson 2011-01-10 16:47:23 PST 
Committed r75452: <http://trac.webkit.org/changeset/75452>