Bug 52173 – [GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

We currently use a few GTK+ methods that have been deprecated in the GTK+ 3.x. We need to remove them or protect them with #ifdefs.

[Martin Robinson]

Created attachment 78462 [details]
Patch

[Xan Lopez]

Comment on attachment 78462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78462&action=review

> WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:275
> +    GdkColor color = { 1, 0, 0, 0 };

Changing this seems a bit pointless? I hope it's right ;) /me too lazy to check

> WebKit/gtk/webkit/webkitwebview.cpp:1553
> +    GdkModifierType modifier = static_cast<GdkModifierType>(0);

This made more sense in plural.

[Martin Robinson]

Committed r75444: <http://trac.webkit.org/changeset/75444>

[Philippe Normand]

This broke the 32-bits release build. 3 tests crashing

[Philippe Normand]

Sorry, one test breaks only: 
media/context-menu-actions.html

0  0x00007f18dfe3b3a8 in g_object_unref (_object=0x3267220) at gobject.c:2658
2658      g_return_if_fail (G_IS_OBJECT (object));


#0  0x00007f18dfe3b3a8 in g_object_unref (_object=0x3267220) at gobject.c:2658
#1  0x00007f18e2597502 in FullscreenVideoController::enterFullscreen() ()
   from /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-1.0.so.0
#2  0x00007f18e292049d in WebCore::HTMLMediaElement::enterFullscreen() ()
   from /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-1.0.so.0
#3  0x00007f18e2b5c984 in WebCore::MediaControlFullscreenButtonElement::defaultEventHandler(WebCore::Event*) ()
   from /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-1.0.so.0
#4  0x00007f18e27eb010 in WebCore::Node::dispatchGenericEvent(WTF::PassRefPtr<WebCore::Event>) ()
   from /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-1.0.so.0
#5  0x00007f18e27eb3d0 in WebCore::Node::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) ()
   from /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-1.0.so.0
...

[Philippe Normand]

I think the crash happen because GRefPtrGtk.h is not included. 

http://trac.webkit.org/changeset/75605 should fix this.