RESOLVED INVALID52171
On GTK < 2.17.3 webkitgtk failed to build 
https://bugs.webkit.org/show_bug.cgi?id=52171
Summary On GTK < 2.17.3 webkitgtk failed to build
Bakhtiar Hasmanan
Reported 2011-01-10 15:23:47 PST
DumpRenderTree ... WebKitTools/DumpRenderTree/gtk/EventSender.cpp: In function 'bool prepareMouseButtonEvent(GdkEvent*, int)': WebKitTools/DumpRenderTree/gtk/EventSender.cpp:136: error: 'getRootCoords' was not declared in this scope make[1]: *** [WebKitTools/DumpRenderTree/gtk/Programs_DumpRenderTree-EventSender.o] Error 1 make: *** [all] Error 2 I've lookup for getRootCoords in GTK APIs and there is no such. The closest function is gdk_window_get_origin(), probably a typo? in ChromeClientGtk.cpp GtkAllocation also redefined for GTK < 2.18 In windows I would avoid GTK 2.18-2.22 because still very buggy
Attachments
fix build on old beloved GTK 2.16 (2.45 KB, patch)
2011-01-20 06:43 PST, Bakhtiar Hasmanan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bakhtiar Hasmanan
Comment 1 2011-01-20 06:43:17 PST
Created attachment 79595 [details] fix build on old beloved GTK 2.16
Oliver Gerlich
Comment 2 2011-02-15 12:41:58 PST
The problem with GtkAllocation being redefined occurred for me as well (with GTK 2.16). The getRootCoords() function should be available in EventSender.cpp itself but above the place where it's used. This should be fixed by the change at http://trac.webkit.org/changeset/60845 ; it worked for me at least.
Bakhtiar Hasmanan
Comment 3 2011-02-15 13:16:01 PST
OK I see that getRootCoords() now
Alberto Garcia
Comment 4 2013-05-31 03:23:34 PDT
This is no longer relevant, we require GTK+ > 2.24.10 now
Note You need to log in before you can comment on or make changes to this bug.