RESOLVED FIXED 52170
[GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code 
https://bugs.webkit.org/show_bug.cgi?id=52170
Summary [GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code
Martin Robinson
Reported 2011-01-10 13:34:22 PST
Now that the GtkStyleContext port is complete, we can remove all of the WidgetRenderingContext and Gtk 2.x specific RenderThemeGtk code from the GTK+ 3.x port.
Attachments
Patch (74.99 KB, patch)
2011-01-10 13:44 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch including new WidgetRenderingContext.cpp (95.78 KB, patch)
2011-01-10 13:57 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-01-10 13:44:38 PST
Created attachment 78444 [details] Patch
WebKit Review Bot
Comment 2 2011-01-10 13:52:28 PST
Attachment 78444 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7405130
Martin Robinson
Comment 3 2011-01-10 13:57:48 PST
Created attachment 78448 [details] Patch including new WidgetRenderingContext.cpp For some reason webkit-patch isn't picking up the file move WidgetRenderingContextGtk2.cpp -> WidgetRenderingContext.cpp. I've uploaded the patch manually.
Xan Lopez
Comment 4 2011-01-10 14:02:06 PST
Comment on attachment 78448 [details] Patch including new WidgetRenderingContext.cpp Sooooo, holy crap and stuff. r=me
Martin Robinson
Comment 5 2011-01-10 14:05:04 PST
Comment on attachment 78448 [details] Patch including new WidgetRenderingContext.cpp Clearing flags on attachment: 78448 Committed r75437: <http://trac.webkit.org/changeset/75437>
Martin Robinson
Comment 6 2011-01-10 14:05:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.