Bug 52170 - [GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code
Summary: [GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 50820
  Show dependency tree / graph
 
Reported: 2011-01-10 13:34 PST by Martin Robinson
Modified: 2011-01-10 14:05 PST (History)
3 users (show)

See Also:

Attachments
Patch (74.99 KB, patch)
2011-01-10 13:44 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch including new WidgetRenderingContext.cpp (95.78 KB, patch)
2011-01-10 13:57 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-01-10 13:34:22 PST 
Now that the GtkStyleContext port is complete, we can remove all of the WidgetRenderingContext and Gtk 2.x specific RenderThemeGtk code from the GTK+ 3.x port.
Comment 1 Martin Robinson 2011-01-10 13:44:38 PST 
Created attachment 78444 [details]
Patch
Comment 2 WebKit Review Bot 2011-01-10 13:52:28 PST 
Attachment 78444 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7405130
Comment 3 Martin Robinson 2011-01-10 13:57:48 PST 
Created attachment 78448 [details]
Patch including new WidgetRenderingContext.cpp

For some reason webkit-patch isn't picking up the file move WidgetRenderingContextGtk2.cpp -> WidgetRenderingContext.cpp. I've uploaded the patch manually.
Comment 4 Xan Lopez 2011-01-10 14:02:06 PST 
Comment on attachment 78448 [details]
Patch including new WidgetRenderingContext.cpp

Sooooo, holy crap and stuff. r=me
Comment 5 Martin Robinson 2011-01-10 14:05:04 PST 
Comment on attachment 78448 [details]
Patch including new WidgetRenderingContext.cpp

Clearing flags on attachment: 78448

Committed r75437: <http://trac.webkit.org/changeset/75437>
Comment 6 Martin Robinson 2011-01-10 14:05:08 PST 
All reviewed patches have been landed.  Closing bug.