Bug 52161 - style-queue messages are way too long for big patches
Summary: style-queue messages are way too long for big patches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-10 11:33 PST by Eric Seidel (no email)
Modified: 2011-01-10 14:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.05 KB, patch)
2011-01-10 12:09 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (3.04 KB, patch)
2011-01-10 12:55 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-01-10 11:33:48 PST 
style-queue messages are way too long for big patches

https://bugs.webkit.org/show_bug.cgi?id=52040#c3

This is due to a change last month to pass the list of changed files to check-webkit-style.  Since we want to keep that change, we should make ScriptError message-to-string functionality smarter about long argument lists.
Comment 1 Eric Seidel (no email) 2011-01-10 12:09:27 PST 
Created attachment 78424 [details]
Patch
Comment 2 Ojan Vafai 2011-01-10 12:50:05 PST 
Comment on attachment 78424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78424&action=review

> Tools/Scripts/webkitpy/common/system/executive.py:59
> +        # We coula make this much fancier, but for now this is OK.

typo: coula
Comment 3 Eric Seidel (no email) 2011-01-10 12:55:13 PST 
Created attachment 78434 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2011-01-10 14:38:13 PST 
Comment on attachment 78434 [details]
Patch for landing

Clearing flags on attachment: 78434

Committed r75438: <http://trac.webkit.org/changeset/75438>
Comment 5 WebKit Commit Bot 2011-01-10 14:38:20 PST 
All reviewed patches have been landed.  Closing bug.