Bug 52152 - Chromium DevTools: get rid of APU-related code in WebKit/chromium
Summary: Chromium DevTools: get rid of APU-related code in WebKit/chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-10 09:04 PST by Pavel Feldman
Modified: 2011-01-11 04:32 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed change. (9.43 KB, patch)
2011-01-10 09:36 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-10 09:04:32 PST 
APU should pretend to be an alternate devtools front-end.
Comment 1 Pavel Feldman 2011-01-10 09:36:30 PST 
Created attachment 78405 [details]
[PATCH] Proposed change.
Comment 2 James Robinson 2011-01-10 11:37:17 PST 
Are the changes under WebCore/ meant to be part of this patch?
Comment 3 Pavel Feldman 2011-01-10 12:02:03 PST 
(In reply to comment #2)
> Are the changes under WebCore/ meant to be part of this patch?

Yes. This is a drive-by. Frontend reuse code went to WebCore (and now can be used both by Chromium port and WebKit2). It just became obvious that it belongs there while I was getting rid of APU.
Comment 4 Yury Semikhatsky 2011-01-11 04:24:28 PST 
Comment on attachment 78405 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=78405&action=review

> Source/WebCore/inspector/InspectorController.cpp:-503
> -void InspectorController::reuseFrontend()

Please remove this from the header as well.

> WebKit/chromium/src/WebDevToolsAgentImpl.cpp:-402
> -        m_client->sendDispatchToAPU(message);

sendDispatchToAPU should go away
Comment 5 Pavel Feldman 2011-01-11 04:32:12 PST 
Comment on attachment 78405 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 78405

Committed r75486: <http://trac.webkit.org/changeset/75486>
Comment 6 Pavel Feldman 2011-01-11 04:32:22 PST 
All reviewed patches have been landed.  Closing bug.