Bug 52146 - [WK2] Support for ARM's RVCT compiler in WKBase.h
Summary: [WK2] Support for ARM's RVCT compiler in WKBase.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Siddharth Mathur
Depends on:
Blocks: 50251
  Show dependency treegraph
Reported: 2011-01-10 07:23 PST by Siddharth Mathur
Modified: 2011-01-10 12:07 PST (History)
3 users (show)

See Also:

Patch (1.15 KB, patch)
2011-01-10 09:35 PST, Siddharth Mathur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Siddharth Mathur 2011-01-10 07:23:31 PST
Similar to Microsoft's compilers, ARM's RVCT (ARMCC) compiler supports  __declspec(dllexport) directive to indicate a DLL export. Update WebKit2/Shared/API/c/WKBase.h to reflect this. Additionally, passing ARMCC the GNU compatbility flag causes the __GNUC__ macro to be implicitly defined, so explicitly guard against use of __attribute__((visibility("default"))).
Comment 1 Siddharth Mathur 2011-01-10 09:35:53 PST
Created attachment 78404 [details]
Comment 2 Eric Seidel (no email) 2011-01-10 11:30:10 PST
Comment on attachment 78404 [details]

OK.  rs=me.
Comment 3 Eric Seidel (no email) 2011-01-10 11:30:38 PST
CCing Gavin who might know something about ARM.
Comment 4 Gavin Barraclough 2011-01-10 12:06:06 PST
Don't really know anything about this, but would have RS'ed too!
Comment 5 WebKit Commit Bot 2011-01-10 12:06:23 PST
The commit-queue encountered the following flaky tests while processing attachment 78404 [details]:

security/block-test-no-port.html bug 52164 (author: pam@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-01-10 12:07:45 PST
Comment on attachment 78404 [details]

Clearing flags on attachment: 78404

Committed r75404: <http://trac.webkit.org/changeset/75404>
Comment 7 WebKit Commit Bot 2011-01-10 12:07:51 PST
All reviewed patches have been landed.  Closing bug.