Bug 52141 – [Chromium] Issue 57432: Layout Test fast/canvas/drawImage-with-negative-source-destination.html failing with --accelerated-2d-canvas

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Naoki Takano]

Created attachment 78379 [details]
Fix shader program

Issue 57432:	Layout Test fast/canvas/drawImage-with-negative-source-destination.html failing with --accelerated-2d-canvas

Originally the test result was following,

run_webkit_tests --accelerated-2d-canvas fast/canvas/drawImage-with-negative-source-destination.html

Txt diffs:

--- D:\src\chromium1\src\webkit\Release\layout-test-results\fast/canvas/drawImage-with-negative-source-destination-expected.txt 
+++ D:\src\chromium1\src\webkit\Release\layout-test-results\fast/canvas/drawImage-with-negative-source-destination-actual.txt 
@@ -3,8 +3,8 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS imgdata[4] is 0
-PASS imgdata[5] is 255
+FAIL imgdata[4] should be 0. Was 255.
+FAIL imgdata[5] should be 255. Was 0.
 PASS imgdata[6] is 0
 PASS successfullyParsed is true

[Naoki Takano]

Could you review my patch?

This is originally reported in Chromium project, but the same error can be shown in WebKit itself.

Thanks,

[Adam Barth]

Comment on attachment 78379 [details]
Fix shader program

Thanks for the patch, but all patches need to have a ChangeLog entry that describes why we're making the change.  In the case, you'll want to mention the test that you're fixing and why we should replace texCoord with gl_TexCoord[0].  This page has more detailed information: http://webkit.org/coding/contributing.html

[Stephen White]

Comment on attachment 78379 [details]
Fix shader program

View in context: https://bugs.webkit.org/attachment.cgi?id=78379&action=review

> WebCore/platform/graphics/gpu/TexShader.cpp:58
> +        "    gl_TexCoord[0] = texMatrix * position;\n"

This fix doesn't make sense to me.  AFAIK, gl_TexCoord is not available in OpenGL ES 2.0 (and deprecated as of desktop GLSL 1.3) and we shouldn't be introducing it into new code.  It's possible that this worked due to some kind of artifact of the GLES2 -> desktop GL translation, but we shouldn't be relying on that.

[Stephen White]

Created attachment 78463 [details]
Patch

[James Robinson]

Comment on attachment 78463 [details]
Patch

R=me

[Naoki Takano]

I see,

Anyway, thank you for your patch!!

It is good study for me;-)

[Stephen White]

Committed r75469: <http://trac.webkit.org/changeset/75469>