Bug 52130 – Support 'disabled' attribute on SVGStyleElement

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Simon Fraser (smfr)]

DOM1/DOM2 describe a 'disabled' attribute on HTMLStyleElements <http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-16428977>. This is being fixed for HTML via bug 25287, but we should probably make it work for SVG also.

[Rob Buis]

This is probably an easy fix. However before even starting I am verifying on www-svg, because the exact wording makes it a bit hard to figure out whether this is in the SVG spec or not.
Chhers,

Rob.

[Dirk Schulze]

(In reply to comment #1)
> This is probably an easy fix. However before even starting I am verifying on www-svg, because the exact wording makes it a bit hard to figure out whether this is in the SVG spec or not.

It isn't in SVG, but it is really just copy&paste from HTMLStyleElement(idl,h,cpp) to SVGStyleElement(idl,h,cpp). But it seems to be very useful. We should suggest it on www-svg and implement it as a demonstration.

[Bear Travis]

Created attachment 125210 [details]
proposed patch adding disabled

[Bear Travis]

The proposed patch adds the disabled attribute to SVGStyleElement(.idl, .h, .cpp).
The code is almost identical to:
https://bugs.webkit.org/show_bug.cgi?id=25287

The patch does not include the reflection tests from 25287 because SVGStyleElement does not yet have a "sheet" attribute in the .idl.

[Bear Travis]

Created attachment 125220 [details]
updated patch

updating patch changelogs to be more descriptive

[Dirk Schulze]

Comment on attachment 125220 [details]
updated patch

Great patch! r=me

Please set the r? and cq? flags if you want this patch get reviewed in the future.

[WebKit Review Bot]

Comment on attachment 125220 [details]
updated patch

Clearing flags on attachment: 125220

Committed r106623: <http://trac.webkit.org/changeset/106623>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.