Split machine stack marking functions into their own class (MachineStackMarker)
Created attachment 78285 [details] Patch
Attachment 78285 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/APIShims.h', u'Source/JavaScriptCore/Android.mk', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/JavaScriptCore.gypi', u'Source/JavaScriptCore/JavaScriptCore.pro', u'Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/runtime/Collector.cpp', u'Source/JavaScriptCore/runtime/Collector.h', u'Source/JavaScriptCore/runtime/JSGlobalData.h', u'Source/JavaScriptCore/runtime/MachineStackMarker.cpp', u'Source/JavaScriptCore/runtime/MachineStackMarker.h']" exit_code: 1 Source/JavaScriptCore/runtime/MachineStackMarker.cpp:41: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:49: "stdlib.h" already included at Source/JavaScriptCore/runtime/MachineStackMarker.cpp:28 [build/include] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:68: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:69: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:190: Use 0 instead of NULL. [readability/null] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:249: usword_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:278: Missing spaces around / [whitespace/operators] [3] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:278: user_count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:281: user_count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:284: user_count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:287: user_count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MachineStackMarker.cpp:290: user_count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MachineStackMarker.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 13 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 78285 [details] Patch please check the style errors, though if they're all in existing code you should need to fix before moving.
Comment on attachment 78285 [details] Patch Asking the commit queue to land this, since I'm out of time today.
Comment on attachment 78285 [details] Patch Rejecting attachment 78285 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'apply-attachment', '--no-update', '--non-interactive', 78285]" exit_code: 2 Last 500 characters of output: e Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj patching file Source/JavaScriptCore/runtime/Collector.cpp patching file Source/JavaScriptCore/runtime/Collector.h patching file Source/JavaScriptCore/runtime/JSGlobalData.h patching file Source/JavaScriptCore/runtime/MachineStackMarker.cpp patching file Source/JavaScriptCore/runtime/MachineStackMarker.h Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Gavin Barraclough', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7367064
Committed r75342: <http://trac.webkit.org/changeset/75342>