Bug 52087 - Move all SVG renderer to WebCore/rendering/svg
Summary: Move all SVG renderer to WebCore/rendering/svg
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-07 15:18 PST by Dirk Schulze
Modified: 2011-01-09 04:36 PST (History)
3 users (show)

See Also:


Attachments
Patch (862.57 KB, patch)
2011-01-07 15:25 PST, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (873.46 KB, patch)
2011-01-09 00:15 PST, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (874.18 KB, patch)
2011-01-09 02:52 PST, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-01-07 15:18:48 PST
Move all SVG renderer to WebCore/rendering/svg
Comment 1 Dirk Schulze 2011-01-07 15:25:55 PST
Created attachment 78283 [details]
Patch
Comment 2 Dirk Schulze 2011-01-07 15:27:21 PST
Please don't review the patch above. Just testing the build. Will clear the review flag when all build bots are ready.
Comment 3 Dirk Schulze 2011-01-07 15:45:34 PST
Comment on attachment 78283 [details]
Patch

Hm. I'll try to clean up the code according to the webkit style and try uploading this patch later, when less changes occur to the build systems. When ever this will be :-/
Comment 4 Zoltan Herczeg 2011-01-07 22:56:28 PST
Why? Is this a new policy?
Comment 5 Dirk Schulze 2011-01-07 23:00:51 PST
(In reply to comment #4)
> Why? Is this a new policy?

Talked on webkit-dev about it. I think it makes much more sense to move code to the type specific folders. I think even the renderer for mathml should move to rendering/mathml and if WML has renderers too, they should move to rendering/wml. Makes the structure of rendering/ much more readable.
Comment 6 Dirk Schulze 2011-01-09 00:15:02 PST
Created attachment 78343 [details]
Patch
Comment 7 Early Warning System Bot 2011-01-09 01:25:20 PST
Attachment 78343 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7371076
Comment 8 Dirk Schulze 2011-01-09 02:52:47 PST
Created attachment 78348 [details]
Patch
Comment 9 Dirk Schulze 2011-01-09 04:12:08 PST
It looks like the EWS bots are not sync to trunk. The patch applies and builds with trunk. Checked it locally.
Comment 10 Nikolas Zimmermann 2011-01-09 04:15:55 PST
Comment on attachment 78348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78348&action=review

r=me.

> Source/WebCore/GNUmakefile.am:2922
> +	Source/WebCore/rendering/svg/RenderForeignObject.cpp \
> +	Source/WebCore/rendering/svg/RenderForeignObject.h \

This should be renamed RenderSVGForeignObject, do you plan to do this in a follow-up patch?
Comment 11 Dirk Schulze 2011-01-09 04:18:49 PST
(In reply to comment #10)
> (From update of attachment 78348 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78348&action=review
> 
> r=me.
> 
> > Source/WebCore/GNUmakefile.am:2922
> > +	Source/WebCore/rendering/svg/RenderForeignObject.cpp \
> > +	Source/WebCore/rendering/svg/RenderForeignObject.h \
> 
> This should be renamed RenderSVGForeignObject, do you plan to do this in a follow-up patch?

Yes, I'll prepare a follow-up for review. Thanks.
Comment 12 Dirk Schulze 2011-01-09 04:36:00 PST
Comment on attachment 78348 [details]
Patch

Clearing flags on attachment: 78348

Committed r75350: <http://trac.webkit.org/changeset/75350>
Comment 13 Dirk Schulze 2011-01-09 04:36:24 PST
All reviewed patches have been landed.  Closing bug.