Bug 52086 - Make WebKitTestRunner rest between loads more robust to avoid test crashes
Summary: Make WebKitTestRunner rest between loads more robust to avoid test crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-07 15:05 PST by Maciej Stachowiak
Modified: 2011-01-07 16:22 PST (History)
0 users

See Also:

Attachments
Patch (4.16 KB, patch)
2011-01-07 15:07 PST, Maciej Stachowiak 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2011-01-07 15:05:28 PST 
Make WebKitTestRunner rest between loads more robust to avoid test crashes
Comment 1 Maciej Stachowiak 2011-01-07 15:07:02 PST 
Created attachment 78278 [details]
Patch
Comment 2 Sam Weinig 2011-01-07 15:50:33 PST 
Comment on attachment 78278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78278&action=review

If you remove the debug code, this looks fine.  r=me

> Tools/WebKitTestRunner/TestController.cpp:40
> -static const double defaultShortTimeout = 5;
> +static const double defaultShortTimeout = 30;

You should revert this.

> Tools/WebKitTestRunner/TestController.cpp:364
> +    platformRunUntil(done, timeoutDuration == (TimeoutDuration)(-15) ? 3600 : timeoutDuration == ShortTimeout ? m_shortTimeout : m_longTimeout);

This too.

> Tools/WebKitTestRunner/TestInvocation.cpp:135
> +    TestController::shared().runUntil(m_gotFinalMessage, (TestController::TimeoutDuration)(-13));

Here too.
Comment 3 Maciej Stachowiak 2011-01-07 16:22:00 PST 
Committed r75291: <http://trac.webkit.org/changeset/75291>