Bug 52081 - [Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
Summary: [Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Trivial
Assignee: Benjamin Poulain
URL:
Keywords: Qt, QtTriaged
Depends on: 50080 52077 52137
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-07 13:49 PST by Benjamin Poulain
Modified: 2011-01-10 12:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2011-01-07 14:01 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
GDB backtrace in debug mode (9.66 KB, text/plain)
2011-01-09 18:26 PST, Csaba Osztrogonác 		no flags Details
Patch (3.67 KB, patch)
2011-01-10 11:56 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-01-07 13:49:06 PST 
Since https://bugs.webkit.org/show_bug.cgi?id=50080, cookiesEnabled() returns true even when the cookie jar is null.
Comment 1 Benjamin Poulain 2011-01-07 14:01:40 PST 
Created attachment 78266 [details]
Patch

I think it is ok regarding the thread safety because this check is in the thread that has the possibility to change the cookie jar, so both action cannot happen simultaneously.
Comment 2 WebKit Commit Bot 2011-01-08 17:29:16 PST 
The commit-queue encountered the following flaky tests while processing attachment 78266 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2011-01-08 17:30:41 PST 
Comment on attachment 78266 [details]
Patch

Clearing flags on attachment: 78266

Committed r75337: <http://trac.webkit.org/changeset/75337>
Comment 4 WebKit Commit Bot 2011-01-08 17:30:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2011-01-09 18:25:54 PST 
It made fast/dom/navigator-detached-no-crash.html crash.
Comment 6 Csaba Osztrogonác 2011-01-09 18:26:42 PST 
Created attachment 78361 [details]
GDB backtrace in debug mode
Comment 7 Antonio Gomes 2011-01-09 19:13:08 PST 
Rolled out. Reopening...
Comment 8 Benjamin Poulain 2011-01-10 11:56:40 PST 
Created attachment 78421 [details]
Patch
Comment 9 Benjamin Poulain 2011-01-10 11:58:22 PST 
(In reply to comment #5)
> It made fast/dom/navigator-detached-no-crash.html crash.

It is really a strange case. The function can be called on an invalid object, I must test for the validity of the manager before calling anything on it.

I am glad the autotest have catched that.
Comment 10 Kenneth Rohde Christiansen 2011-01-10 11:58:50 PST 
Comment on attachment 78421 [details]
Patch

Should work this time around :-)
Comment 11 WebKit Commit Bot 2011-01-10 12:30:29 PST 
Comment on attachment 78421 [details]
Patch

Clearing flags on attachment: 78421

Committed r75411: <http://trac.webkit.org/changeset/75411>
Comment 12 WebKit Commit Bot 2011-01-10 12:30:36 PST 
All reviewed patches have been landed.  Closing bug.