Bug 52066 - commit-queue/webkit-patch should use python 2.6 to run test-webkitpy if available.
Summary: commit-queue/webkit-patch should use python 2.6 to run test-webkitpy if avail...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-07 09:27 PST by Eric Seidel (no email)
Modified: 2012-05-04 12:13 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-01-07 09:27:10 PST 
commit-queue/webkit-patch should use python 2.5 to run test-webkitpy if available.

This would prevent patches which use "with" without importing with_statement from landing if nothing else.

See bug 50901 as one example of when this would have been useful.
Comment 1 Dirk Pranke 2011-01-18 15:48:58 PST 
Alternatively, check-webkit-style could maybe warn about backwards-compatibility issues like this.
Comment 2 Dirk Pranke 2012-05-04 12:13:28 PDT 
closing since 2.6 is required now ...