Bug 52064 - [chromium] Layout test fast/events/overflow-events.html is flaky
Summary: [chromium] Layout test fast/events/overflow-events.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-07 08:39 PST by Stephen White
Modified: 2012-06-13 10:56 PDT (History)
4 users (show)

See Also:

Attachments
Proposed unflakynessing try. (4.55 KB, patch)
2012-03-01 19:40 PST, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Better unflakynessing. (4.45 KB, patch)
2012-03-02 09:00 PST, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-01-07 08:39:58 PST 
Seems to be only flaky on chromium-win debug, for now.
Comment 1 Peter Kasting 2011-08-25 09:53:55 PDT 
Now also flaky on Mac and Linux debug.
Comment 2 Julien Chaffraix 2012-03-01 19:40:46 PST 
Created attachment 129795 [details]
Proposed unflakynessing try.
Comment 3 Stephen White 2012-03-02 04:29:05 PST 
Comment on attachment 129795 [details]
Proposed unflakynessing try.

View in context: https://bugs.webkit.org/attachment.cgi?id=129795&action=review

> LayoutTests/fast/events/overflow-events.html:38
> +        if (currentTest == testResults.length - 1) {
> +            finished("SUCCESS");
> +            return;
> +        }

Since this comes before verification of the test results, won't it skip verification of the last test?
Comment 4 Julien Chaffraix 2012-03-02 08:49:58 PST 
Comment on attachment 129795 [details]
Proposed unflakynessing try.

View in context: https://bugs.webkit.org/attachment.cgi?id=129795&action=review

>> LayoutTests/fast/events/overflow-events.html:38
>> +        }
> 
> Since this comes before verification of the test results, won't it skip verification of the last test?

I think you are right, let me tweak that so it's less error-prone.
Comment 5 Julien Chaffraix 2012-03-02 09:00:26 PST 
Created attachment 129908 [details]
Better unflakynessing.
Comment 6 WebKit Review Bot 2012-03-02 12:01:28 PST 
Comment on attachment 129908 [details]
Better unflakynessing.

Clearing flags on attachment: 129908

Committed r109595: <http://trac.webkit.org/changeset/109595>
Comment 7 WebKit Review Bot 2012-03-02 12:01:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Julien Chaffraix 2012-06-13 10:56:32 PDT 
The test is not flaky anymore so I removed the entry in http://trac.webkit.org/changeset/120225