Bug 52062 - [chromium] Layout test fast/frames/iframe-reparenting-plugins.html is failing on windows
Summary: [chromium] Layout test fast/frames/iframe-reparenting-plugins.html is failing...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Jenn Braithwaite
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-07 08:21 PST by Stephen White
Modified: 2011-01-20 17:44 PST (History)
3 users (show)

See Also:

Attachments
patch (716 bytes, patch)
2011-01-10 15:08 PST, Jenn Braithwaite 		no flags Details | Formatted Diff | Diff
real patch ;-) (1.33 KB, patch)
2011-01-10 15:14 PST, Jenn Braithwaite 		dimich: review+
dimich: commit-queue-
Details | Formatted Diff | Diff
patch (2.03 KB, patch)
2011-01-10 15:25 PST, Jenn Braithwaite 		dimich: review+
dimich: commit-queue-
Details | Formatted Diff | Diff
patch (1.43 KB, patch)
2011-01-20 17:32 PST, Jenn Braithwaite 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-01-07 08:21:52 PST 
Layout test fast/frames/iframe-reparenting-plugins.html introduced at r75169 is failing on chrome windows:

This test verifies that plugin and mimetype in an iframe that is reparented to a different page continue to behave correctly.

Loaded window 2.
FAIL: Failed to find test plugin

Adopted iframe to first page.
Window 2 unloaded.
FAIL: Failed to find test plugin
Comment 1 Jenn Braithwaite 2011-01-10 15:08:56 PST 
Created attachment 78455 [details]
patch
Comment 2 Jenn Braithwaite 2011-01-10 15:14:11 PST 
Created attachment 78457 [details]
real patch ;-)

Forgot ChangeLog earlier. Oops.
Comment 3 Dmitry Titov 2011-01-10 15:17:19 PST 
Comment on attachment 78457 [details]
real patch ;-)

Will land it manually.
Comment 4 Jenn Braithwaite 2011-01-10 15:25:27 PST 
Created attachment 78459 [details]
patch

Moved previous change disabling the test into the BUG_TONY grouping higher in the file.
Comment 5 Dmitry Titov 2011-01-10 15:26:47 PST 
Comment on attachment 78459 [details]
patch

r=me
Comment 6 Dmitry Titov 2011-01-10 15:32:51 PST 
Landed: http://trac.webkit.org/changeset/75442
Comment 7 Jenn Braithwaite 2011-01-20 17:32:39 PST 
Created attachment 79672 [details]
patch

Test is now passing on Windows. Removing test from test_expectations.txt.
Comment 8 Dmitry Titov 2011-01-20 17:39:24 PST 
Comment on attachment 79672 [details]
patch

r=me. I'll land it.
Comment 9 Dmitry Titov 2011-01-20 17:44:40 PST 
Landed test_expectations update: http://trac.webkit.org/changeset/76317