I've attached two testcases, which both fail on TOT. One problem is that syntax errors return with a line number that's relative to the current parsing unit instead of the current file. One step toward fixing this would be to change the && test to an || test in setExceptionDetailsIfNeeded. That would cause exception information for syntax errors to be (re)set by the enclosing node. But that really just begs the question of why we set the information incorrectly to begin with. So I think a better solution would be to change our code so that it only sets the information if it has valid data with which to do so.
Created attachment 4115 [details] Test1
Created attachment 4116 [details] Test1
Created attachment 4117 [details] Test2
Created attachment 4118 [details] Test2
Created attachment 20930 [details] Test 1 (corrected)
Created attachment 20931 [details] Test 2 (corrected)
Still happens with WebKit nightly build r32778 on Mac OS X 10.5.x Leopard with Safari 3.1.1.
<rdar://problem/5907896>
A layout test for what looks like the same issue is proposed in bug 22608, and will need new expected results when this is fixed.
(In reply to comment #5) > Created an attachment (id=20930) [details] > Test 1 (corrected) This test case still does not report a line number with WebKit nightly build r120705, so it's not fixed yet. (In reply to comment #6) > Created an attachment (id=20931) [details] > Test 2 (corrected) This test case reports a correct file and line number as of WebKit nightly build r120705, so it is fixed. (Likely fixed by Bug 62613.)
Note that <rdar://problem/5907896> was used to represent the fix for Bug 62613, so I will file a new radar for the remaining test case that's not fixed: Test 1 (corrected) (Attachment 20930 [details]).
Created attachment 148462 [details] Add Tests Patch v1
Comment on attachment 148462 [details] Add Tests Patch v1 Attachment 148462 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12998097 New failing tests: fast/js/parse-error-external-script-in-new-Function.html fast/js/parse-error-external-script-in-eval.html
Created attachment 148493 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 148585 [details] Add Tests Patch v2
Comment on attachment 148585 [details] Add Tests Patch v2 LGTM.
Looks like this got forgotten?
Comment on attachment 148585 [details] Add Tests Patch v2 Clearing flags on attachment: 148585 Committed r149743: <http://trac.webkit.org/changeset/149743>
All reviewed patches have been landed. Closing bug.