RESOLVED FIXED 52054
[GTK] Port progressbar painting to GtkStyleContext 
https://bugs.webkit.org/show_bug.cgi?id=52054
Summary [GTK] Port progressbar painting to GtkStyleContext
Carlos Garcia Campos
Reported 2011-01-07 05:23:58 PST
Use GtkStyleContext api to paint progressbarsd when using gtk3
Attachments
Use GtkStyleContext API to paint progressbars (6.76 KB, patch)
2011-01-07 05:32 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-01-07 05:32:08 PST
Created attachment 78224 [details] Use GtkStyleContext API to paint progressbars
Martin Robinson
Comment 2 2011-01-08 12:43:03 PST
Comment on attachment 78224 [details] Use GtkStyleContext API to paint progressbars View in context: https://bugs.webkit.org/attachment.cgi?id=78224&action=review Looks great, but please see below before landing this. > WebCore/platform/gtk/RenderThemeGtk3.cpp:369 > +static const int progressActivityBlocks = 5; > +static const int progressAnimationFrames = 10; > +static const double progressAnimationInterval = 0.125; Include a comment before these values which explains where they originate from. > WebCore/platform/gtk/RenderThemeGtk3.cpp:411 > + double progress = renderProgress->animationProgress(); I think this should be called animationProgress, to avoid confusing it with the actual progress position. Please just rename before landing. Thanks!
Carlos Garcia Campos
Comment 3 2011-01-10 01:10:18 PST
Committed r75364: <http://trac.webkit.org/changeset/75364>
Note You need to log in before you can comment on or make changes to this bug.