Bug 52054 - [GTK] Port progressbar painting to GtkStyleContext
Summary: [GTK] Port progressbar painting to GtkStyleContext
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 50820
  Show dependency treegraph
Reported: 2011-01-07 05:23 PST by Carlos Garcia Campos
Modified: 2011-01-10 01:10 PST (History)
1 user (show)

See Also:

Use GtkStyleContext API to paint progressbars (6.76 KB, patch)
2011-01-07 05:32 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-01-07 05:23:58 PST
Use GtkStyleContext api to paint progressbarsd when using gtk3
Comment 1 Carlos Garcia Campos 2011-01-07 05:32:08 PST
Created attachment 78224 [details]
Use GtkStyleContext API to paint progressbars
Comment 2 Martin Robinson 2011-01-08 12:43:03 PST
Comment on attachment 78224 [details]
Use GtkStyleContext API to paint progressbars

View in context: https://bugs.webkit.org/attachment.cgi?id=78224&action=review

Looks great, but please see below before landing this.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:369
> +static const int progressActivityBlocks = 5;
> +static const int progressAnimationFrames = 10;
> +static const double progressAnimationInterval = 0.125;

Include a comment before these values which explains where they originate from.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:411
> +        double progress = renderProgress->animationProgress();

I think this should be called animationProgress, to avoid confusing it with the actual progress position. Please just rename before landing. Thanks!
Comment 3 Carlos Garcia Campos 2011-01-10 01:10:18 PST
Committed r75364: <http://trac.webkit.org/changeset/75364>