Bug 52031 - [WIN] Add ProxyServerWin.cpp
Summary: [WIN] Add ProxyServerWin.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 52109
  Show dependency tree / graph
 
Reported: 2011-01-06 15:24 PST by Patrick R. Gansterer
Modified: 2011-01-10 10:14 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2011-01-06 15:30 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-01-06 15:24:59 PST 
see patch
Comment 1 Patrick R. Gansterer 2011-01-06 15:30:33 PST 
Created attachment 78177 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-06 23:12:07 PST 
Comment on attachment 78177 [details]
Patch

OK.  Does the CPP file need to be wrapped in #if ENABLE()?
Comment 3 Patrick R. Gansterer 2011-01-07 01:30:45 PST 
(In reply to comment #2)
> (From update of attachment 78177 [details])
> OK.  Does the CPP file need to be wrapped in #if ENABLE()?

No. It will be used (linked) only when the NSAPI is enabled, otherwise they will be ignored while linking.
Comment 4 Laszlo Gombos 2011-01-10 08:45:25 PST 
Comment on attachment 78177 [details]
Patch

LGTM, r+. ResourceHandleWin.cpp seems to be a similar case; no guard as it is only picked up by WinCE build system.

I would still prefer to have some indication in the cpp files that these are at the moment only for WinCE (e.g. OS(x) guard), but it seems that this should be done for some other files as well, so perhaps it should be a separate patch.
Comment 5 WebKit Commit Bot 2011-01-10 10:14:19 PST 
Comment on attachment 78177 [details]
Patch

Clearing flags on attachment: 78177

Committed r75383: <http://trac.webkit.org/changeset/75383>
Comment 6 WebKit Commit Bot 2011-01-10 10:14:27 PST 
All reviewed patches have been landed.  Closing bug.