RESOLVED INVALID 52020
Member variables do not begin with m_ in QPageClientWidgetQt and QPageClientGraphicsWidgetQt 
https://bugs.webkit.org/show_bug.cgi?id=52020
Summary Member variables do not begin with m_ in QPageClientWidgetQt and QPageClientG...
Carol Szabo
Reported 2011-01-06 14:44:59 PST
Naming a member variable "view" is not correct according to the WebKit style guidelines. Furthermore makes it difficult to distinguish such a member from an argument named "view".
Attachments
Proposed Patch (16.42 KB, patch)
2011-01-06 15:26 PST, Carol Szabo 		kling: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carol Szabo
Comment 1 2011-01-06 15:26:49 PST
Created attachment 78176 [details] Proposed Patch
Andreas Kling
Comment 2 2011-01-07 03:58:24 PST
Comment on attachment 78176 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78176&action=review The general rule is that public member variables don't have an "m_" prefix. You could make them private and add setters/getters as needed. > WebKit/qt/WebCoreSupport/PageClientQt.h:58 > - : view(newView) > - , page(newPage) > + : m_view(newView) > + , m_page(newPage) > #if USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER) > , syncTimer(this, &PageClientQWidget::syncLayers) > , platformLayerProxy(0) > #endif Looks like you missed 'syncTimer' and 'platformLayerProxy'.
Note You need to log in before you can comment on or make changes to this bug.