Bug 52020 - Member variables do not begin with m_ in QPageClientWidgetQt and QPageClientGraphicsWidgetQt
Summary: Member variables do not begin with m_ in QPageClientWidgetQt and QPageClientG...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Carol Szabo
Depends on:
Blocks: 49184
  Show dependency treegraph
Reported: 2011-01-06 14:44 PST by Carol Szabo
Modified: 2011-01-07 09:24 PST (History)
0 users

See Also:

Proposed Patch (16.42 KB, patch)
2011-01-06 15:26 PST, Carol Szabo
kling: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carol Szabo 2011-01-06 14:44:59 PST
Naming a member variable "view" is not correct according to the WebKit style guidelines. Furthermore makes it difficult to distinguish such a member from an argument named "view".
Comment 1 Carol Szabo 2011-01-06 15:26:49 PST
Created attachment 78176 [details]
Proposed Patch
Comment 2 Andreas Kling 2011-01-07 03:58:24 PST
Comment on attachment 78176 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78176&action=review

The general rule is that public member variables don't have an "m_" prefix.
You could make them private and add setters/getters as needed.

> WebKit/qt/WebCoreSupport/PageClientQt.h:58
> -        : view(newView)
> -        , page(newPage)
> +        : m_view(newView)
> +        , m_page(newPage)
>          , syncTimer(this, &PageClientQWidget::syncLayers)
>          , platformLayerProxy(0)
>  #endif

Looks like you missed 'syncTimer' and 'platformLayerProxy'.