WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52012
Test Result Server not removing old results.
https://bugs.webkit.org/show_bug.cgi?id=52012
Summary
Test Result Server not removing old results.
Julie Parent
Reported
2011-01-06 13:06:40 PST
Simple off-by-one error: If the number of results for the first result is equal to the value we truncate results at, subsequent results never get removed. Example: Given {"results":[[200,"F"],[1,"N"]], "times":[[200,0],[1,2]]}, merging in a new failing result should remove the old "N" entry, yielding: {"results":[[200,"F"], "times":[[200,0]}, but currently yields {"results":[[200,"F"],[1,"N"]], "times":[[200,0],[1,2]]}.
Attachments
Patch
(2.55 KB, patch)
2011-01-06 14:14 PST
,
Julie Parent
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julie Parent
Comment 1
2011-01-06 14:14:56 PST
Created
attachment 78159
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-01-06 23:13:46 PST
Comment on
attachment 78159
[details]
Patch rs=me.
WebKit Commit Bot
Comment 3
2011-01-06 23:31:30 PST
Comment on
attachment 78159
[details]
Patch Clearing flags on attachment: 78159 Committed
r75234
: <
http://trac.webkit.org/changeset/75234
>
WebKit Commit Bot
Comment 4
2011-01-06 23:31:37 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5
2011-01-07 02:34:41 PST
http://trac.webkit.org/changeset/75234
might have broken Leopard Intel Debug (Tests)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug