REOPENED 52011
JSC bindings should use RuntimeEnabledFeatures 
https://bugs.webkit.org/show_bug.cgi?id=52011
Summary JSC bindings should use RuntimeEnabledFeatures
Joe Mason
Reported 2011-01-06 12:58:37 PST
Only the V8 bindings generate code to enable/disable Javascript features that have the EnabledAtRuntime attribute, even though the RuntimeEnabledFeatures class is in bindings/generic so it's available to JSC. This would allow attributes to be completely removed if they are disabled (simply returning "undefined" is not good enough because they will still be visible in iteration). This needs at least: - code added to CodeGeneratorJS.pm to parallel that in CodeGeneratorV8.pm that checks EnabledAtRuntime (or better yet move these checks into common helpers) - possibly added to the other CodeGenerator scripts as well? - existing uses of RuntimeEnabledFeatures that are wrapped in "#if USE(V8)" need to be audited to see if they should now be unconditional - RuntimeEnabledFeatures needs to be added to the build for all platforms using JSC
Attachments
Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2012-10-18 11:51:38 PDT
<rdar://problem/10155019>
Kent Tamura
Comment 2 2012-11-28 21:45:40 PST
*** Bug 91199 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
Comment 3 2013-05-15 09:19:55 PDT
*** This bug has been marked as a duplicate of bug 116147 ***
Chris Dumez
Comment 4 2013-05-15 09:32:08 PDT
(In reply to comment #3) > > *** This bug has been marked as a duplicate of bug 116147 *** Actually, I think we can keep the other one open make add a dependency. My patch only adds support for global constructors. Work will still be needed to extend that to regular attributes and operations.
Ryosuke Niwa
Comment 5 2013-05-15 09:35:45 PDT
Okay.
Note You need to log in before you can comment on or make changes to this bug.