Bug 51979 – Fix percentage values in radius of radial gradients

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

We don't correctly handle % radii for -webkit-radial-gradient.

[Simon Fraser (smfr)]

Created attachment 78094 [details]
Patch

[Darin Adler]

Comment on attachment 78094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78094&action=review

> WebCore/css/CSSGradientValue.cpp:603
> -float CSSRadialGradientValue::resolveRadius(CSSPrimitiveValue* radius, RenderStyle* style, RenderStyle* rootStyle)
> +float CSSRadialGradientValue::resolveRadius(CSSPrimitiveValue* radius, RenderStyle* style, RenderStyle* rootStyle, float widthOrHeight, bool allowPercentage)

If you make it const float* widthOrHeightForPercentage then you could pass 0 to mean percentage is not allowed. Sadly, you can’t take a pointer to the width or height function result of a FloatSize. Another idea would be to use NAN to mean there is no width or height to compute the percentage of.

> WebCore/css/CSSGradientValue.cpp:723
> +        secondRadius = resolveRadius(m_endHorizontalSize.get(), renderer->style(), rootStyle, size.width(), true);
> +        aspectRatio = secondRadius / resolveRadius(m_endVerticalSize.get(), renderer->style(), rootStyle, size.height(), true);

The true here is mysterious. This usually pushes us to use enums or some alternate design that avoids a mystery bool.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/75136