Bug 51974 – Atomics.h has incorrect GCC test for ext/atomicity.h when using LSB compilers

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Craig Scott]

In JacaScriptCore/wtf/Atomics.h the following code block can be found around line 64:

#if OS(WINDOWS)
#include <windows.h>
#elif OS(DARWIN)
#include <libkern/OSAtomic.h>
#elif OS(ANDROID)
#include <cutils/atomic.h>
#elif COMPILER(GCC) && !OS(SYMBIAN)
#if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2))
#include <ext/atomicity.h>
#else
#include <bits/atomicity.h>
#endif
#endif

The test for the GCC version is not correct when the LSB compiler is being used under linux, since the LSB headers only have bits/atomicity.h and not ext/atomicity.h. A more correct test would be:

#if ((__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2))) && !defined(__LSB_VERSION__)


For reference, the LSB and Qt bug trackers also have corresponding entries about this particular webkit issue:

http://bugs.linuxbase.org/show_bug.cgi?id=2522
http://bugreports.qt.nokia.com/browse/QTBUG-16329

[Patrick R. Gansterer]

Can you provide a patch for this? See http://webkit.org/coding/contributing.html

[Jędrzej Nowacki]

As far I understand ext/atomicity.h file should not be included at all.

The file starts from this warning:
/** @file atomicity.h
 *  This is an internal header file, included by other library headers.
 *  You should not attempt to use it directly.
 */

Changing status to New

[Alvaro Lopez Ortega]

Created attachment 149104 [details]
Patch

[Simon Hausmann]

Would you like help landing this, i.e. using the commit queue?

[Craig Scott]

Not sure what the holdup is here. Alvaro provided a patch, so I'm assuming your last comment was directed to him. My changed employment arrangements mean I no longer can commit time to these issues myself.

[WebKit Review Bot]

Comment on attachment 149104 [details]
Patch

Clearing flags on attachment: 149104

Committed r125010: <http://trac.webkit.org/changeset/125010>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.